From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Thompson Subject: Re: [PATCH] gnu: Add freeimage. Date: Sun, 02 Nov 2014 12:55:01 -0500 Message-ID: <87wq7dv66i.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> References: <87egtmx6ox.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <20141101165950.GA10580@debian> <87bnoqx2do.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <20141102174652.GD6865@debian> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkzMt-0000Qp-A9 for guix-devel@gnu.org; Sun, 02 Nov 2014 12:55:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XkzMn-0000z9-63 for guix-devel@gnu.org; Sun, 02 Nov 2014 12:55:11 -0500 Received: from na3sys009aog135.obsmtp.com ([74.125.149.84]:59243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkzMm-0000xH-Ud for guix-devel@gnu.org; Sun, 02 Nov 2014 12:55:05 -0500 Received: by mail-qa0-f49.google.com with SMTP id i13so7223352qae.8 for ; Sun, 02 Nov 2014 09:55:03 -0800 (PST) In-Reply-To: <20141102174652.GD6865@debian> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org Andreas Enge writes: > On Sat, Nov 01, 2014 at 01:21:55PM -0400, David Thompson wrote: >> + '(#:phases (alist-replace >> + 'unpack >> + (lambda* (#:key source #:allow-other-keys) >> + (and (zero? (system* "unzip" source)) >> + (chdir "FreeImage"))) >> + (alist-delete >> + 'configure >> + (alist-cons-before >> + 'build 'patch-makefile >> + (lambda* (#:key outputs #:allow-other-keys) >> + (substitute* "Makefile.gnu" >> + (("/usr") (assoc-ref outputs "out")) >> + (("-o root -g root") ""))) >> + %standard-phases))) > > I think that instead of adding patch-makefile before build, I would let it > replace configure. But this is just a matter of taste, so please do as you > please. That's a fair point, though I have already pushed. Thanks, anyhow. :) -- David Thompson Web Developer - Free Software Foundation - http://fsf.org GPG Key: 0FF1D807 Support the FSF: https://fsf.org/donate