all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Federico Beffa <beffa@fbengineering.ch>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: gnu: python-numpy-bootstrap: Reduce matrix size in failing test.
Date: Sun, 14 Dec 2014 23:54:18 +0100	[thread overview]
Message-ID: <87wq5tu9k5.fsf@gnu.org> (raw)
In-Reply-To: <E1Y0EQZ-0001VA-GJ@vcs.savannah.gnu.org> (Federico Beffa's message of "Sun, 14 Dec 2014 19:01:59 +0000")

Federico Beffa <beffa@fbengineering.ch> skribis:

> +        (alist-cons-before
> +         'check 'fix-failing-tests
> +         (lambda _
> +           (substitute* (find-files "numpy/linalg/tests" 
> +                                    "test_regression\\.py")
> +             (("x = np.eye(1000, 66)")
> +              "x = np.eye(10, 66)")))

Could you add a comment here explaining that this is reducing the input
matrix size (?) and why it matters?  Otherwise it may seem a bit too
magical.  :-)

Also, this kind of change would be a good candidate for ‘snippet’,
because it’s a “static” change.

Thanks,
Ludo’.

       reply	other threads:[~2014-12-14 22:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20141214190158.5716.92499@vcs.savannah.gnu.org>
     [not found] ` <E1Y0EQZ-0001VA-GJ@vcs.savannah.gnu.org>
2014-12-14 22:54   ` Ludovic Courtès [this message]
2014-12-15  8:41     ` 01/01: gnu: python-numpy-bootstrap: Reduce matrix size in failing test Federico Beffa
2014-12-15 12:33       ` Federico Beffa
2014-12-15 17:11         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wq5tu9k5.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=beffa@fbengineering.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.