From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Cech Subject: Re: [PATCH] gnu: luajit: Add -fPIC into CFLAGS. Date: Tue, 16 Dec 2014 22:42:28 +0100 Message-ID: <87wq5rw9tn.wl%tcech@suse.cz> References: <1418683961-28525-1-git-send-email-sleep_walker@suse.cz> <87sigf7cat.fsf@gnu.org> <87zjanwg1p.wl%sleep_walker@suse.cz> <87zjanpaku.fsf@gnu.org> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="Multipart_Tue_Dec_16_22:42:28_2014-1" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0zt0-0002eJ-Pm for guix-devel@gnu.org; Tue, 16 Dec 2014 16:42:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0zss-0005vJ-C3 for guix-devel@gnu.org; Tue, 16 Dec 2014 16:42:30 -0500 In-Reply-To: <87zjanpaku.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Cc: guix-devel@gnu.org --Multipart_Tue_Dec_16_22:42:28_2014-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable At Tue, 16 Dec 2014 22:08:01 +0100, Ludovic Court=C3=A8s wrote: >=20 > Tomas Cech skribis: >=20 > > At Tue, 16 Dec 2014 18:08:10 +0100, > > Ludovic Court=C3=A8s wrote: > >>=20 > >> Tom=C3=A1=C5=A1 =C4=8Cech skribis: > >>=20 > >> > * gnu/packages/lua.scm (luajit): Add -fPIC into CFLAGS and pass it t= o make. > >>=20 > >> [...] > >>=20 > >> > --- a/gnu/packages/lua.scm > >> > +++ b/gnu/packages/lua.scm > >> > @@ -92,7 +92,8 @@ for configuration, scripting, and rapid prototypin= g.") > >> > (arguments > >> > '(#:tests? #f ;luajit is distributed with= out tests > >> > #:phases (alist-delete 'configure %standard-phases) > >> > - #:make-flags (list (string-append "PREFIX=3D" (assoc-ref %ou= tputs "out"))))) > >> > + #:make-flags (list (string-append "CFLAGS=3D-fPIC " (or (get= env "CFLAGS") "")) > >> > + (string-append "PREFIX=3D" (assoc-ref %ou= tputs "out"))))) > >>=20 > >> Could you add a comment explaining why this is needed? > > > > OK, I'll do. But I don't know details and linking during build of EFL > > failed when this was missing. Is this level of explanation sufficient? >=20 > Interestingly luajit contains both a .so and a .a; src/Makefile has the > rule to build .o files: >=20 > --8<---------------cut here---------------start------------->8--- > %.o: %.c > $(E) "CC $@" > $(Q)$(TARGET_DYNCC) $(TARGET_ACFLAGS) -c -o $(@:.o=3D_dyn.o) $< > $(Q)$(TARGET_CC) $(TARGET_ACFLAGS) -c -o $@ $< > --8<---------------cut here---------------end--------------->8--- >=20 > Where $(TARGET_DYNCC) does use -fPIC. >=20 > So it all looks normal. What=E2=80=99s the exact error you were getting = when > building EFL? CCLD lib/ecore_ipc/libecore_ipc.la ld: /gnu/store/ij22m0lalbagkm4fflnxc9691ax4bpvk-luajit-2.0.3/lib/libluajit-= 5.1.a(lj_err.o): relocation R_X86_64_32S against `.rodata' cannot be used w= hen making a shared object; recompile with -fPIC /gnu/store/ij22m0lalbagkm4fflnxc9691ax4bpvk-luajit-2.0.3/lib/libluajit-5.1.= a: error adding symbols: Bad value collect2: error: ld returned 1 exit status Makefile:16352: recipe for target 'lib/evas/libevas.la' failed make[4]: *** [lib/evas/libevas.la] Error 1 make[4]: *** Waiting for unfinished jobs.... Makefile:31933: recipe for target 'all-recursive' failed make[3]: *** [all-recursive] Error 1 Makefile:11593: recipe for target 'all' failed make[2]: *** [all] Error 2 Makefile:2284: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 Makefile:1514: recipe for target 'all' failed make: *** [all] Error 2 phase `build' failed after 114 seconds I attached current state of my efl.scm. Only efl was building correctly so = far. Thanks. S_W --Multipart_Tue_Dec_16_22:42:28_2014-1 Content-Type: application/octet-stream Content-Disposition: attachment; filename="efl.scm" Content-Transfer-Encoding: base64 Ozs7IEdOVSBHdWl4IC0tLSBGdW5jdGlvbmFsIHBhY2thZ2UgbWFuYWdlbWVudCBmb3IgR05VCjs7 OyBDb3B5cmlnaHQgwqkgMjAxNCBUb23DocWhIMSMZWNoIDxzbGVlcF93YWxrZXJAc3VzZS5jej4K Ozs7Cjs7OyBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KOzs7Cjs7OyBHTlUgR3VpeCBp cyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5IGl0 Cjs7OyB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFz IHB1Ymxpc2hlZCBieQo7OzsgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZl cnNpb24gMyBvZiB0aGUgTGljZW5zZSwgb3IgKGF0Cjs7OyB5b3VyIG9wdGlvbikgYW55IGxhdGVy IHZlcnNpb24uCjs7Owo7OzsgR05VIEd1aXggaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhh dCBpdCB3aWxsIGJlIHVzZWZ1bCwgYnV0Cjs7OyBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91 dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCjs7OyBNRVJDSEFOVEFCSUxJVFkgb3IgRklU TkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCjs7OyBHTlUgR2VuZXJhbCBQ dWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgo7OzsKOzs7IFlvdSBzaG91bGQgaGF2ZSBy ZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCjs7OyBhbG9u ZyB3aXRoIEdOVSBHdWl4LiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNl cy8+LgoKKGRlZmluZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBlZmwpCiAgIzp1c2UtbW9kdWxlICgo Z3VpeCBsaWNlbnNlcykgIzpwcmVmaXggbGljZW5zZTopCiAgIzp1c2UtbW9kdWxlIChndWl4IHBh Y2thZ2VzKQogICM6dXNlLW1vZHVsZSAoZ3VpeCBkb3dubG9hZCkKICAjOnVzZS1tb2R1bGUgKGd1 aXggYnVpbGQtc3lzdGVtIGdudSkKICAjOnVzZS1tb2R1bGUgKGd1aXggYnVpbGQtc3lzdGVtIGNt YWtlKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzKQogICM6dXNlLW1vZHVsZSAoZ251IHBh Y2thZ2VzIGJhc2gpCiAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgY3VybCkKICAjOnVzZS1t b2R1bGUgKGdudSBwYWNrYWdlcyBjb21wcmVzc2lvbikKICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcyBmb250dXRpbHMpCiAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZnJpYmlkaSkKICAj OnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBnYW1lLWRldmVsb3BtZW50KQogICM6dXNlLW1vZHVs ZSAoZ251IHBhY2thZ2VzIGdsaWIpCiAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ25vbWUp CiAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ3N0cmVhbWVyKQogICM6dXNlLW1vZHVsZSAo Z251IHBhY2thZ2VzIGltYWdlKQogICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGxpbnV4KQog ICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGx1YSkKICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcyBnbCkKICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBvcGVuc3NsKQogICM6dXNlLW1v ZHVsZSAoZ251IHBhY2thZ2VzIHB1bHNlYXVkaW8pCiAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgcGhvdG8pCiAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgcGtnLWNvbmZpZykKICAjOnVz ZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB2YWxncmluZCkKICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcyB4b3JnKSkKCihkZWZpbmUtcHVibGljIGVmbAogIChwYWNrYWdlCiAgICAobmFtZSAiZWZs IikKICAgICh2ZXJzaW9uICIxLjEyLjIiKQogICAgKHNvdXJjZSAob3JpZ2luCiAgICAgICAgICAg ICAgKG1ldGhvZCB1cmwtZmV0Y2gpCiAgICAgICAgICAgICAgKHVyaSAoc3RyaW5nLWFwcGVuZCAi aHR0cDovL2Rvd25sb2FkLmVubGlnaHRlbm1lbnQub3JnL3JlbC9saWJzL2VmbC9lZmwtIiB2ZXJz aW9uICIudGFyLmd6IikpCiAgICAgICAgICAgICAgKHNoYTI1NgogICAgICAgICAgICAgICAoYmFz ZTMyICIxa254bTR4aXF4cHZwc3poeXFpazQzbHczNmhkd2RmaDh6N3k2MjgwM2E3MDkzajN5am53 IikpKSkKICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKICAgIChuYXRpdmUtaW5w dXRzCiAgICAgYCgoInBrZy1jb25maWciICxwa2ctY29uZmlnKSkpCiAgICAoaW5wdXRzCiAgICAg YCgoImFsc2EtbGliIiAsYWxzYS1saWIpCiAgICAgICAoImJhc2giICxiYXNoKQogICAgICAgKCJj b21wb3NpdGVwcm90byIgLGNvbXBvc2l0ZXByb3RvKQogICAgICAgKCJidWxsZXQiICxidWxsZXQp CiAgICAgICAoImN1cmwiICxjdXJsKQogICAgICAgKCJkYnVzIiAsZGJ1cykKICAgICAgICgiZXVk ZXYiICxldWRldikKICAgICAgICgiZm9udGNvbmZpZyIgLGZvbnRjb25maWcpCiAgICAgICAoImZy ZWV0eXBlIiAsZnJlZXR5cGUpCiAgICAgICAoImZyaWJpZGkiICxmcmliaWRpKQogICAgICAgKCJn aWZsaWIiICxnaWZsaWIpCiAgICAgICAoImdsaWIiICxnbGliKQogICAgICAgKCJnc3RyZWFtZXIi ICxnc3RyZWFtZXIpCiAgICAgICAoImdzdC1wbHVnaW5zLWJhc2UiICxnc3QtcGx1Z2lucy1iYXNl KQo7ICAgICAgICgiZ3N0LXBsdWdpbnMtZ29vZCIgLGdzdC1wbHVnaW5zLWdvb2QpCiAgICAgICAo ImxpYmV4aWYiICxsaWJleGlmKQogICAgICAgKCJsaWJqcGVnIiAsbGlianBlZykKICAgICAgICgi bGlicG5nIiAsbGlicG5nKQogICAgICAgKCJsaWJyc3ZnIiAsbGlicnN2ZykKICAgICAgICgibGli c25kZmlsZSIgLGxpYnNuZGZpbGUpCiAgICAgICAoImxpYnRpZmYiICxsaWJ0aWZmKQogICAgICAg KCJsaWJ4MTEiICxsaWJ4MTEpCiAgICAgICAoImxpYnhjb21wb3NpdGUiICxsaWJ4Y29tcG9zaXRl KQogICAgICAgKCJsaWJ4Y3Vyc29yIiAsbGlieGN1cnNvcikKICAgICAgICgibGlieGRtY3AiICxs aWJ4ZG1jcCkKICAgICAgICgibGlieGV4dCIgLGxpYnhleHQpCiAgICAgICAoImxpYnhpIiAsbGli eGkpCiAgICAgICAoImxpYnhrYmZpbGUiICxsaWJ4a2JmaWxlKQogICAgICAgKCJsaWJ4aW5lcmFt YSIgLGxpYnhpbmVyYW1hKQogICAgICAgKCJsaWJ4cCIgLGxpYnhwKQogICAgICAgKCJsaWJ4cmFu ZHIiICxsaWJ4cmFuZHIpCiAgICAgICAoImxpYnhzY3Juc2F2ZXIiICxsaWJ4c2NybnNhdmVyKQog ICAgICAgKCJsaWJ4dHN0IiAsbGlieHRzdCkKICAgICAgICgibHVhaml0IiAsbHVhaml0KQogICAg ICAgKCJtZXNhIiAsbWVzYSkKICAgICAgICgib3BlbnNzbCIgLG9wZW5zc2wpCiAgICAgICAoInBy aW50cHJvdG8iICxwcmludHByb3RvKQogICAgICAgKCJwdWxzZWF1ZGlvIiAscHVsc2VhdWRpbykK ICAgICAgICgic2NybnNhdmVycHJvdG8iICxzY3Juc2F2ZXJwcm90bykKICAgICAgICgidXRpbC1s aW51eCIgLHV0aWwtbGludXgpCiAgICAgICAoInZhbGdyaW5kIiAsdmFsZ3JpbmQpCiAgICAgICAo InhleHRwcm90byIgLHhleHRwcm90bykKICAgICAgICgieGlucHV0IiAseGlucHV0KQogICAgICAg KCJ4cHIiICx4cHIpCiAgICAgICAoInhwcm90byIgLHhwcm90bykpKQo7ICAgIChhcmd1bWVudHMK OyAgICAgYCgjOmNvbmZpZ3VyZS1mbGFncyAnKCItLWRpc2FibGUtc3RhdGljIikpKQogICAgKGFy Z3VtZW50cwogICAgIGAoIzpwaGFzZXMKICAgICAgIChhbGlzdC1jb25zLWJlZm9yZQogICAgICAg ICdjb25maWd1cmUgJ3BhdGNoLWNvbmZpZy1maWxlcwogICAgICAgIChsYW1iZGEgXwogICAgICAg ICAgKHN1YnN0aXR1dGUqICJwby9NYWtlZmlsZS5pbi5pbiIKICAgICAgICAgICAgKCgiL2Jpbi9z aCIpICh3aGljaCAiYmFzaCIpKSkpCiAgICAgICAgJXN0YW5kYXJkLXBoYXNlcykpKQogICAgKGhv bWUtcGFnZSAiaHR0cDovL3d3dy5lbmxpZ2h0ZW5tZW50Lm9yZyIpCiAgICAoc3lub3BzaXMgIkVu bGlnaHRlbm1lbnQgRm91bmRhdGlvbiBMaWJyYXJpZXMiKQogICAgKGRlc2NyaXB0aW9uCiAgICAg IkVGTCBpcyB0b29sa2l0IHVzZWQgbWFpbmx5IGZvciBFbmxpZ2h0ZW5tZW50LCBidXQgaXMgdXNl ZCBmb3IgbW9yZSBhcHBsaWNhdGlvbnMgYmVjYXVzZSBpdCBpcyByZXNvdXJjZSBmcmllbmRseSBh bmQgZW5lcmd5IGVmZmljaWVudC4iKQogICAgKGxpY2Vuc2UgKGxpc3QgbGljZW5zZTpic2QtMiBs aWNlbnNlOmxncGwyLjEgbGljZW5zZTp6bGliKSkpKSA7IGRpZmZlcmVudCBwYXJ0cyB1bmRlciBk aWZmZXJlbnQgbGljZW5zZXMKCihkZWZpbmUtcHVibGljIGVsZW1lbnRhcnkKICAocGFja2FnZQog ICAgKG5hbWUgImVsZW1lbnRhcnkiKQogICAgKHZlcnNpb24gIjEuMTIuMiIpCiAgICAoc291cmNl IChvcmlnaW4KICAgICAgICAgICAgICAobWV0aG9kIHVybC1mZXRjaCkKICAgICAgICAgICAgICAo dXJpIChzdHJpbmctYXBwZW5kICJodHRwOi8vZG93bmxvYWQuZW5saWdodGVubWVudC5vcmcvcmVs L2xpYnMvZWxlbWVudGFyeS9lbGVtZW50YXJ5LSIgdmVyc2lvbiAiLnRhci5neiIpKQogICAgICAg ICAgICAgIChzaGEyNTYKICAgICAgICAgICAgICAgKGJhc2UzMiAiMHFqYmhkaG53Nmg1emMwNXIy dzJqMzh5YXBjdjlrbTkyazVzcGN3M3pzZG5jNzg0dmY1aSIpKSkpCiAgICAoYnVpbGQtc3lzdGVt IGdudS1idWlsZC1zeXN0ZW0pCiAgICAobmF0aXZlLWlucHV0cwogICAgIGAoKCJwa2ctY29uZmln IiAscGtnLWNvbmZpZykpKQogICAgKGlucHV0cwogICAgIGAoCjsgICAgICAgKCJmcmliaWRpIiAs ZnJpYmlkaSkKOyAgICAgICAoImxpYnBuZyIgLGxpYnBuZykKOyAgICAgICAoImxpYngxMSIgLGxp YngxMSkKOyAgICAgICAoImxpYnhpbmVyYW1hIiAsbGlieGluZXJhbWEpCiAgICAgICAoImVmbCIg LGVmbCkpKQo7ICAgICAgICgib3BlbnNzbCIgLG9wZW5zc2wpKSkpCjsgICAgICAgKCJ6bGliIiAs emxpYikpKQogICAgKGhvbWUtcGFnZSAiaHR0cDovL3d3dy5lbmxpZ2h0ZW5tZW50Lm9yZyIpCiAg ICAoc3lub3BzaXMgIldpZGdldCBsaWJyYXJ5IG9mIEVubGlnaHRlbm1lbnQgd29ybGQiKQogICAg KGRlc2NyaXB0aW9uCiAgICAgIkVGTCBpcyB0b29sa2l0IHVzZWQgbWFpbmx5IGZvciBFbmxpZ2h0 ZW5tZW50LCBidXQgaXMgdXNlZCBmb3IgbW9yZSBhcHBsaWNhdGlvbnMgYmVjYXVzZSBpdCBpcyBy ZXNvdXJjZSBmcmllbmRseSBhbmQgZW5lcmd5IGVmZmljaWVudC4iKQogICAgKGxpY2Vuc2UgbGlj ZW5zZTpsZ3BsMi4xKSkpCgooZGVmaW5lLXB1YmxpYyBldmFzLWdlbmVyaWMtbG9hZGVycwogIChw YWNrYWdlCiAgICAobmFtZSAiZXZhcy1nZW5lcmljLWxvYWRlcnMiKQogICAgKHZlcnNpb24gIjEu MTIuMCIpCiAgICAoc291cmNlIChvcmlnaW4KICAgICAgICAgICAgICAobWV0aG9kIHVybC1mZXRj aCkKICAgICAgICAgICAgICAodXJpIChzdHJpbmctYXBwZW5kICJodHRwOi8vZG93bmxvYWQuZW5s aWdodGVubWVudC5vcmcvcmVsL2xpYnMvZW1vdGlvbl9nZW5lcmljX3BsYXllcnMvZW1vdGlvbl9n ZW5lcmljX3BsYXllcnMtIiB2ZXJzaW9uICIudGFyLmd6IikpCiAgICAgICAgICAgICAgKHNoYTI1 NgogICAgICAgICAgICAgICAoYmFzZTMyICIxbm0wcWJka2hycGd2bWo1cW43bDRqajVsMWc0eno3 N2JkYTBkZHk2N2Zxa241aDNxYXJnIikpKSkKICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5 c3RlbSkKICAgIChpbnB1dHMKICAgICBgKCgibGlieDExIiAsbGlieDExKQogICAgICAgKCJsaWJ4 aW5lcmFtYSIgLGxpYnhpbmVyYW1hKQogICAgICAgKCJlZmwiICxlZmwpKSkKICAgIChob21lLXBh Z2UgImh0dHA6Ly93d3cuZW5saWdodGVubWVudC5vcmciKQogICAgKHN5bm9wc2lzICJXaWRnZXQg bGlicmFyeSBvZiBFbmxpZ2h0ZW5tZW50IHdvcmxkIikKICAgIChkZXNjcmlwdGlvbgogICAgICJF RkwgaXMgdG9vbGtpdCB1c2VkIG1haW5seSBmb3IgRW5saWdodGVubWVudCwgYnV0IGlzIHVzZWQg Zm9yIG1vcmUgYXBwbGljYXRpb25zIGJlY2F1c2UgaXQgaXMgcmVzb3VyY2UgZnJpZW5kbHkgYW5k IGVuZXJneSBlZmZpY2llbnQuIikKICAgIChsaWNlbnNlIGxpY2Vuc2U6bGdwbDIuMSkpKQo= --Multipart_Tue_Dec_16_22:42:28_2014-1--