From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH v2]: Add Ardour.
Date: Wed, 11 Feb 2015 23:51:32 +0100
Message-ID: <87wq3om58r.fsf@mango.localdomain>
References: <87sieqyby5.fsf@mango.localdomain> <87k2zowyrd.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46131)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1YLg8O-0000sd-Ti
	for guix-devel@gnu.org; Wed, 11 Feb 2015 17:51:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1YLg8N-0000lM-UC
	for guix-devel@gnu.org; Wed, 11 Feb 2015 17:51:52 -0500
In-reply-to: <87k2zowyrd.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>


Ludovic Courtès writes:

> In the future, could you use separate email threads, à la ‘git
> send-email’?  That makes more reasonably sized bites.  :-)

Sorry about that.  I'll remember to chunk 'em a little more nicely in
the future.

>> From a13f49d293eebf5d6de5170a4dfc0b9885a90c26 Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <rekado@elephly.net>
>> Date: Fri, 30 Jan 2015 18:14:00 +0100
>> Subject: [PATCH 11/15] gnu: Add Vamp SDK.
>>
>> * gnu/packages/audio.scm (vamp): New variable.
>
> [...]
>
>> +    (home-page "http://vamp-plugins.org")
>> +    (synopsis "Vamp audio plugin SDK")
>
> What about “Modular and extensible audio processing system”?

Okay.

>> +    (license
>> +     (license:bsd-style
>> +      "https://code.soundsoftware.ac.uk/projects/vamp-plugin-sdk/repository/entry/COPYING"))))
>
> Should be ‘x11-style’, see <http://directory.fsf.org/wiki/License:X11>.

Okay.

>> +    (home-page "http://breakfastquay.com/rubberband/")
>> +    (synopsis "Audio time-stretching and pitch-shifting library")
>> +    (description
>> +     "Rubber Band is a library and utility program that permits changing the
>> +tempo and pitch of an audio recording independently of one another.")
>> +    (license license:gpl2)))
>
> Isn’t it GPLv2+, according to <http://breakfastquay.com/rubberband/license.html>?

Yes, that's right.  I spend what felt like a long time reading the
project page and the README but only saw mention of GPLv2.  I need to
make it a habit to also check a couple more file headers.

Pushed with these changes.

Thank you so much for your reviews!

~~ Ricardo