From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Various icedtea6 patches Date: Thu, 19 Mar 2015 10:07:26 +0100 Message-ID: <87wq2d5p9t.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYWQk-00084m-Om for guix-devel@gnu.org; Thu, 19 Mar 2015 05:08:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYWQM-0005qD-0S for guix-devel@gnu.org; Thu, 19 Mar 2015 05:07:54 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYWQL-0005q9-U5 for guix-devel@gnu.org; Thu, 19 Mar 2015 05:07:29 -0400 In-Reply-To: (Ricardo Wurmus's message of "Tue, 17 Mar 2015 14:18:50 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel Ricardo Wurmus skribis: > From 3bc3dd46ebec97acf424bbc8b3026ee23fdafa19 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Tue, 10 Mar 2015 13:56:55 +0100 > Subject: [PATCH 1/5] gnu: icedtea6: patch ant shebang in unpack phase > > * gnu/packages/java.scm (icedtea6)[arguments]: patch bootstrap ant in the > `unpack' phase instead of `patch-paths'. OK. > From 0d8261286f0d4a14b65359c7f23276f9d166c49e Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Tue, 10 Mar 2015 14:00:55 +0100 > Subject: [PATCH 2/5] gnu: icedtea6: patch hardcoded objcopy path. > > * gnu/packages/java.scm (icedtea6)[arguments]: patch Makefile to override > DEF_OBJCOPY variable definition. OK. > From 9c9ef4fde4003a3bc9af73462552edde5d46c909 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Tue, 10 Mar 2015 14:05:48 +0100 > Subject: [PATCH 3/5] gnu: icedtea6: patch patches in separate build phase. > > * gnu/packages/java.scm (icedtea6)[arguments]: patch patches in a separate > build phase `patch-patches' instead of `patch-paths'. Is it really patches that are being patched? Not obvious from a quick look. Anyway, maybe =E2=80=9CMove patching from =E2=80=98patch-paths=E2=80=99 to = new =E2=80=98patch-patches=E2=80=99 phase.=E2=80=9D > From 7b4a5b8861de9f8f940d8bf60e225fcafbbb2b1c Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Tue, 10 Mar 2015 17:03:44 +0100 > Subject: [PATCH 4/5] gnu: icedtea6: rename build phase `set-paths' > > * gnu/packages/java.scm (icedtea6)[arguments]: Avoid overriding standard > `set-paths' phase by renaming new phase to `set-additional-paths'. Just =E2=80=9CRename =E2=80=98set-paths=E2=80=99 phase to =E2=80=98set-addi= tional-paths=E2=80=99.=E2=80=9D However the removal of CC and LD_LIBRARY_PATH should be made a separate patch. > From 0c2f26564987721c7ec112cfa0d8d714ef4fda01 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Tue, 17 Mar 2015 14:12:14 +0100 > Subject: [PATCH 5/5] gnu: icedtea6: remove commented substitution. > > * gnu/packages/java.scm (icedtea6): Remove commented substitution. OK. Thanks, Ludo=E2=80=99.