From mboxrd@z Thu Jan 1 00:00:00 1970 From: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1?= =?utf-8?Q?=2FKammer?=) Subject: Re: [PATCH] gnu: mesa: Add libva input. Date: Thu, 30 Apr 2015 09:49:40 +0200 Message-ID: <87wq0ucay3.fsf@taylan.uni.cx> References: <87zj5se6o0.fsf@taylan.uni.cx> <87383kbah1.fsf@gmail.com> <87r3r4dmwq.fsf@taylan.uni.cx> <20150429211211.GB9266@debian> <871tj2eh5t.fsf@taylan.uni.cx> <20150430072934.GA4097@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnjE8-0005xO-6T for guix-devel@gnu.org; Thu, 30 Apr 2015 03:49:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YnjE7-0001wh-8K for guix-devel@gnu.org; Thu, 30 Apr 2015 03:49:44 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:35528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnjE7-0001wd-2A for guix-devel@gnu.org; Thu, 30 Apr 2015 03:49:43 -0400 Received: by widdi4 with SMTP id di4so8637071wid.0 for ; Thu, 30 Apr 2015 00:49:42 -0700 (PDT) In-Reply-To: <20150430072934.GA4097@debian> (Andreas Enge's message of "Thu, 30 Apr 2015 09:29:34 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org Andreas Enge writes: > On Wed, Apr 29, 2015 at 11:52:30PM +0200, Taylan Ulrich Bay=C4=B1rl=C4=B1= /Kammer wrote: >> Right. I don't know what I did wrong before, but it actually seems to >> work fine to put it in gl.scm. New patch: > > Okay, looks good. > > I just realise that libva-without-mesa is maybe a semantically better nam= e. Changed the name. >> - ;; TODO: Solve circular dependency with libva. >> - ;; ("libva" ,libva) >> + ("libva" ,libva-no-mesa) > > Maybe add a comment: "to solve the circular dependency". Added a more elaborate comment above the libva-without-mesa definition. Thanks for the feedback! Taylan