From: Taylan Ulrich Kammer <taylanbayirli@gmail.com>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add guile-emacs!
Date: Thu, 14 May 2015 10:56:23 +0200 [thread overview]
Message-ID: <87wq0bh70o.fsf@gmail.com> (raw)
In-Reply-To: <873830f2m0.fsf@earlgrey.lan> (Christopher Allan Webber's message of "Wed, 13 May 2015 19:01:07 -0500")
Christopher Allan Webber <cwebber@dustycloud.org> writes:
> Okay, how about a version of guile-emacs that works and incorporates
> feedback from this thread? Yeah? Anyone?
>
> Whoooooooooo guile-emacs! :)
Yay! :-)
I would have thought these would go to guile.scm and emacs.scm. What do
others think?
> +(define-public guile-for-guile-emacs
> [...]
> + (inputs
> + `(("gettext" ,gnu-gettext)
Sure it shouldn't be in native-inputs? I'm guessing autogen uses it.
> +(define-public guile-emacs
> [...]
> + (substitute-keyword-arguments `(#:parallel-build? #f
A comment explaining why parallel builds are disabled would be good.
> + ;; Tests aren't passing for now.
> + ;; Obviously we should re-enable this!
> + #:tests? #f
Tests should generally always be enabled so the second line of the
comment would be redundant; just a nitpick. :-)
Otherwise looks good to me. Thanks!
Taylan
next prev parent reply other threads:[~2015-05-14 8:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 19:35 [PATCH] Attempt at packaging guile-emacs (needs help) Christopher Allan Webber
2015-05-10 21:51 ` Mark H Weaver
2015-05-11 2:29 ` Christopher Allan Webber
2015-05-14 0:01 ` [PATCH] Add guile-emacs! Christopher Allan Webber
2015-05-14 8:56 ` Taylan Ulrich Kammer [this message]
2015-05-14 15:53 ` Christopher Allan Webber
2015-05-14 20:06 ` Taylan Ulrich Kammer
2015-05-14 20:52 ` Taylan Ulrich Kammer
2015-05-15 10:13 ` Ludovic Courtès
2015-05-19 17:29 ` Christopher Allan Webber
2015-05-19 18:29 ` Taylan Ulrich Bayırlı/Kammer
2015-05-19 19:41 ` Christopher Allan Webber
2015-05-19 20:24 ` Taylan Ulrich Bayırlı/Kammer
2015-05-20 12:22 ` Ludovic Courtès
2015-05-23 7:26 ` Feng Shu
2015-05-23 17:21 ` Christopher Allan Webber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wq0bh70o.fsf@gmail.com \
--to=taylanbayirli@gmail.com \
--cc=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.