all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andy Wingo <wingo@igalia.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org, Alex Kost <alezost@gmail.com>
Subject: Re: Add guix install command
Date: Fri, 07 Aug 2015 14:01:31 +0200	[thread overview]
Message-ID: <87wpx7gvdw.fsf@igalia.com> (raw)
In-Reply-To: <87h9obpjps.fsf@elephly.net> (Ricardo Wurmus's message of "Fri, 07 Aug 2015 10:48:47 +0200")

On Fri 07 Aug 2015 10:48, Ricardo Wurmus <rekado@elephly.net> writes:

>>> Attached is a patch to implement "guix install".  It just copies over
>>> functionality from guix package.  We could refactor more but I would
>>> start with this as it is; when things need changes is the time to
>>> refactor, at least for me.  What do you think? :)
>>
>> I don't mind the new commands, but I think this patch is unacceptable
>> because of the huge code duplicating.  Sorry if it was sounded rude, I
>
> Would it be possible to implement this with stubs for “guix install” and
> “guix search” that serve as mere aliases to “guix package -i” and “guix
> package -s”?
>
> I think it would be nice to have these commands as long as they are just
> aliases and don’t duplicate code.

In the case of "guix install", yes.  However what would you show for
"guix install --help"?  What would error messages show: "guix package"
or "guix install"?  Would the user perceive it as a separate command or
would the fact that it is an alias be visible to the user?

I have a lot of opinions of course ;) but IMO for a user it's better for
it to present as a separate command.  Why?  Because understanding all of
"guix package" (or simply paging it back into human memory) is harder
than understanding all of "guix install".  Describing "guix install" is
easier than describing "guix package".

Also FWIW the equivalent of "guix package --install-from-expression foo"
is, as of this patch, "guix install --from-expression foo".  Reads nicer
to me but dunno, might be a point of conflict.

For search, I chose to default to a more terse format (--short rather
than --recutils).  Also the --recutils and --short options probably
don't make sense as arguments to "guix package", at least not named how
they are.

Basically it seems to me that "guix package" is doing too much as it
is.  Dunno how you see it though.  I am new here :)

Cheers,

Andy

  reply	other threads:[~2015-08-07 12:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05  9:36 Add guix install command Andy Wingo
2015-08-06 21:08 ` Mathieu Lirzin
2015-08-07  7:47 ` Alex Kost
2015-08-07  8:45   ` Andy Wingo
2015-08-07 19:22     ` Alex Kost
2015-08-07  8:48   ` Ricardo Wurmus
2015-08-07 12:01     ` Andy Wingo [this message]
2015-08-07 12:22       ` Thompson, David
2015-08-07 12:36         ` Andy Wingo
2015-08-07 16:52           ` Chris Marusich
2015-08-18 16:08             ` Ludovic Courtès
2015-08-18 16:23       ` Ludovic Courtès
2015-08-18 17:10         ` Chris Marusich
2015-08-07 10:08   ` Mathieu Lirzin
2015-08-07 19:22     ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpx7gvdw.fsf@igalia.com \
    --to=wingo@igalia.com \
    --cc=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.