From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: Add guix install command Date: Fri, 07 Aug 2015 22:22:34 +0300 Message-ID: <87wpx6rjid.fsf@gmail.com> References: <87pp32ulfj.fsf@igalia.com> <87614rsfpn.fsf@gmail.com> <874mkb9zs5.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNnE0-0006eq-UO for guix-devel@gnu.org; Fri, 07 Aug 2015 15:22:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNnDw-0004SV-BS for guix-devel@gnu.org; Fri, 07 Aug 2015 15:22:40 -0400 Received: from mail-lb0-x22f.google.com ([2a00:1450:4010:c04::22f]:33618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNnDw-0004SE-3H for guix-devel@gnu.org; Fri, 07 Aug 2015 15:22:36 -0400 Received: by lbbyj8 with SMTP id yj8so66287053lbb.0 for ; Fri, 07 Aug 2015 12:22:35 -0700 (PDT) In-Reply-To: <874mkb9zs5.fsf@openmailbox.org> (Mathieu Lirzin's message of "Fri, 07 Aug 2015 12:08:26 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mathieu Lirzin Cc: guix-devel@gnu.org Mathieu Lirzin (2015-08-07 13:08 +0300) wrote: > Alex Kost writes: > >> Andy Wingo (2015-08-05 12:36 +0300) wrote: >>[...] >>> Attached is a patch to implement "guix install". It just copies over >>> functionality from guix package. We could refactor more but I would >>> start with this as it is; when things need changes is the time to >>> refactor, at least for me. What do you think? :) > [...] >> I just think that refactoring needs to be done instead of copying >> pieces from (guix scripts package). > > AIUI doing a "good" refactoring job will imply a lot of code moving > because It means separating the interfaces from the functionalities. > IMO that could be left to next iterations. However, IIUC this patch > could be lighter by using indirections to the 'guix-package' procedure > fornow instead of copying chunks of code. Is that what you mean? No, as Andy pointed you can't just use 'guix-package' procedure for several reasons. My only concern is to avoid the code duplication. I'm afraid that postponing refactoring in practice may mean the code will remain in this state for years. -- Alex