From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] lint: Check non-translated package descriptions.
Date: Tue, 22 Sep 2015 23:36:42 +0200
Message-ID: <87wpvii1at.fsf@gnu.org>
References: <1442929463-19527-1-git-send-email-mthl@openmailbox.org>
	<1442929463-19527-2-git-send-email-mthl@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60169)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZeVEz-0004mz-NL
	for guix-devel@gnu.org; Tue, 22 Sep 2015 17:36:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZeVEy-00046w-Vm
	for guix-devel@gnu.org; Tue, 22 Sep 2015 17:36:45 -0400
In-Reply-To: <1442929463-19527-2-git-send-email-mthl@openmailbox.org> (Mathieu
	Lirzin's message of "Tue, 22 Sep 2015 15:44:22 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mathieu Lirzin <mthl@openmailbox.org>
Cc: guix-devel@gnu.org

Mathieu Lirzin <mthl@openmailbox.org> skribis:

> * guix/ui.scm (texi->plain-text): Export.
> * guix/scripts/lint.scm (check-description-style): Use it instead of
>   'package-description-string'.

[...]

> -      (check-texinfo-markup package)
> -      (check-proper-start description)
> -      (check-end-of-sentence-space description))))
> +      (and=3D> (check-texinfo-markup description)
> +             (lambda (texi)
> +               (check-proper-start texi)
> +               (check-end-of-sentence-space texi))))))

As you suggest, it=E2=80=99s best to keep =E2=80=98check-end-of-sentence-sp=
ace=E2=80=99 before
Texinfo conversion if doing it after would be a no-op.

Could you do that and add a comment above?  OK to push with this change.

Thanks,
Ludo=E2=80=99.