all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Mathieu Lirzin <mthl@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] lint: Check non-translated package descriptions.
Date: Tue, 22 Sep 2015 23:36:42 +0200	[thread overview]
Message-ID: <87wpvii1at.fsf@gnu.org> (raw)
In-Reply-To: <1442929463-19527-2-git-send-email-mthl@openmailbox.org> (Mathieu Lirzin's message of "Tue, 22 Sep 2015 15:44:22 +0200")

Mathieu Lirzin <mthl@openmailbox.org> skribis:

> * guix/ui.scm (texi->plain-text): Export.
> * guix/scripts/lint.scm (check-description-style): Use it instead of
>   'package-description-string'.

[...]

> -      (check-texinfo-markup package)
> -      (check-proper-start description)
> -      (check-end-of-sentence-space description))))
> +      (and=> (check-texinfo-markup description)
> +             (lambda (texi)
> +               (check-proper-start texi)
> +               (check-end-of-sentence-space texi))))))

As you suggest, it’s best to keep ‘check-end-of-sentence-space’ before
Texinfo conversion if doing it after would be a no-op.

Could you do that and add a comment above?  OK to push with this change.

Thanks,
Ludo’.

  reply	other threads:[~2015-09-22 21:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 13:44 [PATCH 0/2] lint: Texinfo again Mathieu Lirzin
2015-09-22 13:44 ` [PATCH 1/2] lint: Check non-translated package descriptions Mathieu Lirzin
2015-09-22 21:36   ` Ludovic Courtès [this message]
2015-09-24 23:04     ` Mathieu Lirzin
2015-09-25 16:17       ` Ludovic Courtès
2015-09-25 21:26         ` Mathieu Lirzin
2015-09-26 13:05           ` Ludovic Courtès
2015-09-26 17:09             ` Mathieu Lirzin
2015-09-27 20:22               ` Ludovic Courtès
2015-09-22 13:44 ` [PATCH 2/2] lint: Accept '`' character Mathieu Lirzin
2015-09-22 21:37   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpvii1at.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mthl@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.