From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: guix: Set 'guix-dot-program' emacs variable. Date: Sat, 17 Oct 2015 15:34:29 +0200 Message-ID: <87wpulk49m.fsf@gnu.org> References: <877fmnkj61.fsf@gmail.com> <87si5buswd.fsf@gnu.org> <87twpqy8qp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZnRd5-00046D-6A for guix-devel@gnu.org; Sat, 17 Oct 2015 09:34:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZnRd1-0002Gw-Uc for guix-devel@gnu.org; Sat, 17 Oct 2015 09:34:35 -0400 In-Reply-To: <87twpqy8qp.fsf@gmail.com> (Alex Kost's message of "Fri, 16 Oct 2015 21:21:50 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > From dd793147718cb18766268c8aad50d24b88ffe6b6 Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Fri, 16 Oct 2015 20:34:32 +0300 > Subject: [PATCH 1/2] build: Set DOT_USER_PROGRAM for Emacs interface. > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > > Suggested by Ludovic Court=C3=A8s . > > * configure.ac: Set DOT_USER_PROGRAM variable. > * emacs/guix-config.el.in (guix-config-dot-program): New constant. > * emacs/guix-external.el (guix-dot-program): Use it. [...] > +(defconst guix-config-dot-program "@DOT_USER_PROGRAM@" > + "Name of the 'dot' executable defined at the configure time.") =E2=80=9Cat configure time=E2=80=9D The docstring should mention that it can be the empty string. Alternately, =E2=80=98configure=E2=80=99 could set DOT_USER_PROGRAM to =E2= =80=9Cdot=E2=80=9D when it=E2=80=99s not found, which I think is ever preferable. WDYT? > +(defcustom guix-dot-program > + (if (string=3D "" guix-config-dot-program) > + (executable-find "dot") > + guix-config-dot-program) Thus here we=E2=80=99d be checking whether =E2=80=98guix-config-dot-program= =E2=80=99 is an absolute file name. > From be9e01b3c2d6ca9f47c5bdac38effe7a7bb707dc Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Fri, 16 Oct 2015 20:48:24 +0300 > Subject: [PATCH 2/2] emacs: config: Use "emacs-config-" prefix for consta= nts. > > * emacs/guix-config.el.in (guix-emacs-interface-directory, > guix-state-directory): Rename to ... > (guix-config-emacs-interface-directory, guix-config-state-directory): > ...this. > (guix-config-guile-program): New constant. > (guix-guile-program): Move to ... > * emacs/guix-external.el (guix-guile-program): ...here. Make it a > 'defcustom'. > * emacs/guix-profiles.el (guix-default-profile): Use > 'guix-config-state-directory'. > * emacs/guix-backend.el (guix-load-path): Use > 'guix-config-emacs-interface-directory'. OK! Thanks, Ludo=E2=80=99.