From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 0/3] emacs: Improve post processing of popup arguments.
Date: Sun, 08 Nov 2015 22:16:21 +0100
Message-ID: <87wptsyyxm.fsf@gnu.org>
References: <1446712749-1553-1-git-send-email-alezost@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40646)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZvXK8-0002yw-UL
	for guix-devel@gnu.org; Sun, 08 Nov 2015 16:16:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZvXK3-0002TJ-UX
	for guix-devel@gnu.org; Sun, 08 Nov 2015 16:16:28 -0500
In-Reply-To: <1446712749-1553-1-git-send-email-alezost@gmail.com> (Alex Kost's
	message of "Thu, 5 Nov 2015 11:39:06 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

Alex Kost <alezost@gmail.com> skribis:

> Hello, this patchset is for adjusting "M-x guix" for the recent
> environment/container changes.  'magit-popup' returns a simple list of
> arguments, and this list needs to be "post-processed".  Previously a
> very simple post-processing (moving the rest "-- ..." arguments to the
> end of the arg list) was enough, but now (for a rather complicated 'guix
> environment' command: positional "--ad-hoc", shell command after '--')
> it should be improved.  So this is the improvement.

Good catch.

> [PATCH 1/3] emacs: Improve post processing of popup arguments.
> [PATCH 2/3] emacs: Adjust 'guix container' popup.
> [PATCH 3/3] emacs: Adjust 'guix environment' popup.

On a cursory look it LGTM.  I don=E2=80=99t grasp the details of #1 but I
trust you.

Thank you!

Ludo=E2=80=99.