Re: [PATCH 2/5] gnu: Add evolution-data-server.

[Alex Kost <alezost@gmail.com>]

宋文武 (2015-11-10 15:51 +0300) wrote:

[...]
> +(define-public evolution-data-server
> +  (package
> +    (name "evolution-data-server")
> +    (version "3.18.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnome/sources/" name "/"
> +                                  (version-major+minor version) "/"
> +                                  name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "16yfd2a00xqxikyf6pi2awfd0qfq4hwdhfar88axrb4mycfgqhjr"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(;; XXX: fails with:
> +       ;;   /Fixture/Calendar0: cleaning up pid xxxx
> +       ;;   t status: 139)
> +       #:tests? #f
> +       #:configure-flags
> +       (let ((nss  (assoc-ref %build-inputs "nss"))
> +             (nspr (assoc-ref %build-inputs "nspr")))
> +         (list "--disable-uoa"    ; disable Ubuntu Online Accounts support
> +               "--disable-google" ; disable Google Contacts support
> +             (string-append "--with-nspr-includes=" nspr "/include/nspr")
> +             (string-append "--with-nss-includes=" nss "/include/nss")
> +             (string-append "--with-nss-libs=" nss "/lib/nss")))
                ^^
Please indent (string-append ...) clauses inside list properly.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before
> +          'check 'pre-check
> +          (lambda _
> +            (substitute* "tests/test-server-utils/e-test-server-utils.c"

I would make it:

         (add-before 'check 'pre-check
           (lambda _
             (substitute* "tests/test-server-utils/e-test-server-utils.c"

but it probably doesn't matter.

> +              (("/bin/rm") (which "rm")))
> +            #t)))))
> +    (native-inputs
> +     `(("glib:bin" ,glib "bin") ; for glib-mkenums, etc.
> +       ("gobject-introspection" ,gobject-introspection)
> +       ("gperf" ,gperf)
> +       ("intltool" ,intltool)
> +       ("pkg-config" ,pkg-config)
> +       ("python" ,python)))
> +    (propagated-inputs
> +     ;; These are all in the Requires field of .pc files.
> +     `(("gtk+" ,gtk+)
> +       ("libical" ,libical)
> +       ("libsecret" ,libsecret)
> +       ("libsoup" ,libsoup)
> +       ("nss" ,nss)
> +       ("sqlite" ,sqlite)))
> +    (inputs
> +     `(("bdb" ,bdb)
> +       ("gcr" ,gcr)
> +       ("gnome-online-accounts" ,gnome-online-accounts)
> +       ("libgweather" ,libgweather)))
> +    (synopsis "Libraries and services for storing addressbooks and calendars")

I think it's better to use "address books".

-- 
Alex