From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: bug#21410: Environment containers
Date: Sat, 21 Nov 2015 16:57:30 +0100
Message-ID: <87wptb9wgl.fsf@gnu.org>
References: <CAJ=RwfbK67QX1tyrd7O_O=EVkxrO9GU3u8k6etMint4ucO8u5A@mail.gmail.com>
	<87y4epsnjs.fsf@T420.taylan>
	<CAJ=RwfakM8CMTyRH-SWoJVnO+__jq2oE_2gy41129Kde2y=u8w@mail.gmail.com>
	<CADrxHD8-pRRgR549eWQG4fNm7Lky=kTT0wSbrbGBgtgRhUZg9Q@mail.gmail.com>
	<87r3kgwpb8.fsf@gnu.org>
	<CADrxHD8hs0UC0Jeqq4BXNMdGAX=Q_bbrw7k31KJkYxjuYO8PSg@mail.gmail.com>
	<87mvv3832q.fsf@gnu.org>
	<CADrxHD-hTbYkOMHzPRmYKjd7HQNmtzgivGkAz0AKAk4w--e2cg@mail.gmail.com>
	<CAJ=RwfZg+ytagyGM73FbT25Btagvxb+eAZn74-0pyx=OqGqkJA@mail.gmail.com>
	<87fv0v6l6v.fsf@gnu.org>
	<CAJ=RwfaxrzGwtSmukse7BRmcRc2uWPfOJ86AbkBQsB40VbXfpg@mail.gmail.com>
	<87eggda36z.fsf@gnu.org>
	<CAJ=RwfYS=KLjymLAeQz7QdYU0oh_hpZN+J3odhsmyQov7sytUA@mail.gmail.com>
	<87r3jkg1vl.fsf@gnu.org>
	<CADrxHD_-pkxwJXWzLRdSp+kvBBcofbOwVccTy=czvAf2zdJKuA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36117)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a0AXg-0004jU-GB
	for guix-devel@gnu.org; Sat, 21 Nov 2015 10:57:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a0AXd-0002MU-8B
	for guix-devel@gnu.org; Sat, 21 Nov 2015 10:57:36 -0500
In-Reply-To: <CADrxHD_-pkxwJXWzLRdSp+kvBBcofbOwVccTy=czvAf2zdJKuA@mail.gmail.com>
	(Alex Vong's message of "Sat, 21 Nov 2015 21:36:31 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Vong <alexvong1995@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>, 21410@debbugs.gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Alex Vong <alexvong1995@gmail.com> skribis:

> FAIL: tests/guix-environment-container
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>
> + set -e
> + guix environment --version
> guix environment (GNU Guix) 0.9.0
> Copyright (C) 2015 the Guix authors
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.h=
tml>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> + tmpdir=3Dt-guix-environment-29930
> + trap 'rm -r "$tmpdir"' EXIT
> + mkdir t-guix-environment-29930
> + guix environment --container --ad-hoc --bootstrap guile-bootstrap -- gu=
ile -c '(exit 42)'
> guix environment: error: cannot create container: unprivileged user canno=
t create user namespaces
> guix environment: error: please set /proc/sys/kernel/unprivileged_userns_=
clone to "1"

Oh I see, that part fell through the cracks.

Could you confirm that the test is skipped with the attached patch?

TIA!

Ludo=E2=80=99.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline

--- a/tests/guix-environment-container.sh
+++ b/tests/guix-environment-container.sh
@@ -24,6 +24,12 @@ set -e
 
 guix environment --version
 
+if ! guile -c '((@@ (guix scripts environment) assert-container-features))'
+then
+    # User containers are not supported; skip this test.
+    exit 77
+fi
+
 tmpdir="t-guix-environment-$$"
 trap 'rm -r "$tmpdir"' EXIT
 

--=-=-=--