From: Alex Kost <alezost@gmail.com>
To: Fabian Harfert <fhmgufs@web.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add package definition for GNU XaoS.
Date: Mon, 21 Dec 2015 15:42:33 +0300 [thread overview]
Message-ID: <87wps83rd2.fsf@gmail.com> (raw)
In-Reply-To: <20151215210203.5d2accca@himbaca> (Fabian Harfert's message of "Tue, 15 Dec 2015 21:02:03 +0100")
Andreas Enge (2015-12-16 04:48 +0300) wrote:
> Maybe it would make sense to kindly remind them to put their releases
> on ftp.gnu.org. That would also allow us to be notified of updates
> (which could be used as an argument).
I was going to commit this patch but now I don't know: should we wait
for a reply from the maintainers about updating xaos release on gnu.org?
Or maybe push this patch now, and change the origin URL later (if there
will be a response)?
Fabian Harfert (2015-12-15 23:02 +0300) wrote:
[...]
> From 6687ea7c21725bdc13e368773d5c7576a43db14e Mon Sep 17 00:00:00 2001
> From: Fabian Harfert <fhmgufs@web.de>
> Date: Tue, 15 Dec 2015 21:00:38 +0100
> Subject: [PATCH] Add package definition for GNU XaoS.
Our convention is to use the following commit message:
--8<---------------cut here---------------start------------->8---
gnu: Add xaos.
* gnu/packages/maths.scm (xaos): New variable.
--8<---------------cut here---------------end--------------->8---
> ---
> gnu/packages/maths.scm | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index 0c0f013..181809c 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -9,6 +9,7 @@
> ;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com>
> ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
> ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
> +;;; Copyright © 2015 Fabian Harfert <fhmgufs@web.de>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -53,6 +54,7 @@
> #:use-module (gnu packages ghostscript)
> #:use-module (gnu packages glib)
> #:use-module (gnu packages gtk)
> + #:use-module (gnu packages image)
Our (gnu packages image) module uses (gnu packages maths). I wouldn't
add this circularity, I think it was better to have xaos in a separate
module. But actually I don't know if it's a real issue and what our
policy on such things is. I hope more experienced guix/guile people
will tell if we should avoid such circularities.
--
Alex
next prev parent reply other threads:[~2015-12-21 12:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 19:51 [PATCH] Add package definition for GNU XaoS Fabian Harfert
2015-12-15 20:02 ` Fabian Harfert
2015-12-21 12:42 ` Alex Kost [this message]
2015-12-21 13:35 ` Ludovic Courtès
2015-12-23 8:48 ` Alex Kost
2015-12-30 15:51 ` Ludovic Courtès
2015-12-31 8:35 ` Alex Kost
2016-01-01 15:56 ` Ludovic Courtès
2015-12-31 8:35 ` Alex Kost
-- strict thread matches above, loose matches on Subject: below --
2015-12-14 21:01 Fabian Harfert
2015-12-14 22:58 ` Leo Famulari
2015-12-15 19:24 ` Alex Kost
2015-12-15 20:45 ` Leo Famulari
2015-12-15 7:22 ` Andreas Enge
2015-12-15 19:23 ` Alex Kost
2015-12-16 1:48 ` Andreas Enge
2015-12-16 17:38 ` Fabian Harfert
2015-12-19 2:24 ` Mark H Weaver
2015-12-15 19:24 ` Alex Kost
2015-12-16 1:09 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wps83rd2.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=fhmgufs@web.de \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.