From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add erlang. Date: Wed, 06 Jan 2016 17:07:51 +0100 Message-ID: <87wprmg088.fsf@gnu.org> References: <20160104043952.GA29303@jasmine> <877fjpzi07.fsf@igalia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <877fjpzi07.fsf@igalia.com> (Andy Wingo's message of "Mon, 04 Jan 2016 12:44:24 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org To: Andy Wingo Cc: guix-devel@gnu.org, 19439@debbugs.gnu.org, Steve Sprang , guile-devel@gnu.org List-Id: guix-devel.gnu.org On Mon 04 Jan 2016 06:20, Steve Sprang writes: > From http://www.erlang.org/download/otp_src_18.2.1.tar.gz... > ERROR: Bad qstring header component: kMSMAn68110840 Andy Wingo skribis: > The Etag value is invalid: > > https://tools.ietf.org/html/rfc7232#section-2.3 > > We could relax Guile's etag parser to assume that an etag not starting > with either W/ or " is a strong etag without quotes. To do that you > would patch guile's http.scm to say: > > (define (parse-entity-tag val) > (cond > ((string-prefix? "W/" val) (cons (parse-qstring val 2) #f)) > ((string-prefix? "\"" val) (cons (parse-qstring val) #t)) > (else (cons val #t)))) > > Considering that this error has come up a few times and that the less > strict parser doesn't change the Guile programming interface or endanger > the web in any significant way, I think changing Guile's HTTP parser > would be OK. > > Thoughts? Indeed, this has been reported a few times: http://bugs.gnu.org/19439 I think we should implement the proposed change. Could you look into it? Thanks, Ludo=E2=80=99.