From: Christopher Allan Webber <cwebber@dustycloud.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: On the MediaGoblin dependency patch updates
Date: Fri, 19 Feb 2016 18:40:14 -0800 [thread overview]
Message-ID: <87wpq0m7b1.fsf@dustycloud.org> (raw)
In-Reply-To: <20160216013418.GC3984@jasmine>
Leo Famulari writes:
> On Mon, Feb 15, 2016 at 03:23:45PM -0800, Christopher Allan Webber wrote:
>> First in a series of towards-MediaGoblin patches.
>
> Awesome!
>
> I'm reviewing these on the assumption that you've tested they all build.
I have, if I forgot to say that previously.
> Are mock and nose required after build-time? If not, they should be
> native-inputs.
>
> As for markupsafe, the latest version of the manual has this to say
> about propagated-inputs:
>
> Another example where propagated-inputs is useful is for languages that
> lack a facility to record the run-time search path akin to ELF’s
> RUNPATH; this includes Guile, Python, Perl, GHC, and more. To ensure
> that libraries written in those languages can find library code they
> depend on at run time, run-time dependencies must be listed in
> propagated-inputs rather than inputs.
>
> I won't mention these potential issues in my reviews of the rest of the
> patches.
I sent a whole new batch of patches for all these, and updated
wip-mediagoblin. The only one not updated was python-mako, which I
removed, since Dave got that into master anyway. It's all rebased,
and Leo's suggestions are all included (with the exception of one
comment where an indentation change was suggested, and I stuck with the
way emacs does it).
So, unless there's any more feedback, the whole lot of these can be
merged into master, and then we can work on MediaGoblin itself.
- Chris
next prev parent reply other threads:[~2016-02-20 2:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 23:23 [PATCH 1/18] gnu: Add python-mako Christopher Allan Webber
2016-02-16 1:34 ` Leo Famulari
2016-02-20 2:40 ` Christopher Allan Webber [this message]
2016-02-20 4:58 ` On the MediaGoblin dependency patch updates Leo Famulari
2016-02-22 3:05 ` Christopher Allan Webber
2016-02-22 3:49 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpq0m7b1.fsf@dustycloud.org \
--to=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.