From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add cgit.
Date: Mon, 28 Mar 2016 18:33:28 +0200
Message-ID: <87wpomr293.fsf@gnu.org>
References: <1459087365-1576-1-git-send-email-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aka6i-0001du-Jn
	for guix-devel@gnu.org; Mon, 28 Mar 2016 12:33:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aka6d-0003CJ-LW
	for guix-devel@gnu.org; Mon, 28 Mar 2016 12:33:36 -0400
In-Reply-To: <1459087365-1576-1-git-send-email-iyzsong@gmail.com>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Sun, 27 Mar 2016 22:02:45 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> * gnu/packages/version-control.scm (cgit): New variable.

[...]

> +    (arguments
> +     '(#:tests? #f ;

Please add a comment on why tests are disabled.  Better yet: fix=E2=80=99em!
;-)

> +    (native-inputs
> +     `(("asciidoc" ,asciidoc)
> +       ("xmllint" ,libxml2)
> +       ("xsltprot" ,libxslt)))
> +    (inputs
> +     `(("docbook-xml" ,docbook-xml)
> +       ("docbook-xsl" ,docbook-xsl)

I would move DocBook to =E2=80=98native-inputs=E2=80=99.

> +    (description
> +     "CGit is an attempt to create a fast web interface for the Git SCM,=
 using
> +a built-in cache to decrease server I/O pressure.")
> +    (license gpl2)))

Version 2 only, right?

Ludo=E2=80=99.