From: Alex Kost <alezost@gmail.com>
To: Mckinley Olsen <mck.olsen@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: add vte-ng
Date: Sat, 09 Apr 2016 11:42:19 +0300 [thread overview]
Message-ID: <87wpo7rx5g.fsf@gmail.com> (raw)
In-Reply-To: <87zitfws0r.fsf@gmail.com> (Alex Kost's message of "Thu, 31 Mar 2016 00:54:44 +0300")
Alex Kost (2016-03-31 00:54 +0300) wrote:
> Mckinley Olsen (2016-03-30 02:52 +0300) wrote:
>
>> Package vte-ng, which is needed by termite terminal (which I hope to
>> package)
>
> Hello, this is a great patch for the first package! I have only a
> couple of nitpicks and one real question.
>
>> From c06b9fe54d33d6c8624426771fbb52606f751f58 Mon Sep 17 00:00:00 2001
>> From: McKinley Olsen <mck.olsen@gmail.com>
>> Date: Mon, 28 Mar 2016 15:03:06 -0600
>> Subject: [PATCH] gnu: add vte-ng.
> Capital "Add" ----------^
>
>> * gnu/packages/gnome.scm (vte-ng): added vte-ng package.
>
> We write it like this:
>
> * gnu/packages/gnome.scm (vte-ng): New variable.
>
>> ---
>> gnu/packages/gnome.scm | 31 +++++++++++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index eebb547..376ee74 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -1755,6 +1755,37 @@ gnome-terminal, but can also be used to embed a console/terminal in games,
>> editors, IDEs, etc.")
>> (license license:lgpl2.1+)))
>>
>> +(define-public vte-ng
>> + (package
>> + (inherit vte)
>> + (name "vte-ng")
>> + (version "0.42.4.a")
>> + (native-inputs
>> + `(("gtk-doc" ,gtk-doc)
>> + ("gperf" ,gperf)
>> + ("autoconf" ,autoconf)
>> + ("automake" ,automake)
>> + ("libtool" ,libtool)
>> + ,@(package-native-inputs vte)))
>> + (source (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url (string-append "https://github.com/thestinger/"
>> + name
>> + ".git"))
>> + (commit version)))
>
>
> Why do you use git instead of the latest tagged source?:
>
> https://github.com/thestinger/vte-ng/archive/0.44.0.a.tar.gz
>
>> + (file-name (string-append name "-" version))
>> + (sha256
>> + (base32
>> + "1w91lz30j5lrskp9ds5j3nn27m5mpdpn7nlcvf5y1w63mpmjg8k1"))))
>> + (arguments
>> + `(#:phases (modify-phases %standard-phases
>> + (add-after 'unpack 'bootstrap
>> + (lambda _
>> + (setenv "NOCONFIGURE" "true")
>> + (zero? (system* "sh" "autogen.sh")))))))))
>
> I think it also would be good to add its own synopsis/description to
> make it clear how it differs from "vte".
Ping! :-)
Could you please send an updated patch with synopsis/description and
with the latest release tarball instead of the git checkout (or explain
in a commentary why a specific git commit is needed).
Also, I'm sorry, but I'm not going to build it, as I don't want to build
'texlive' (vte-ng → gtk-doc → dblatex → texlive). I hope someone else
will do :-)
--
Alex
next prev parent reply other threads:[~2016-04-09 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 23:52 [PATCH] gnu: add vte-ng Mckinley Olsen
2016-03-30 21:54 ` Alex Kost
2016-04-09 8:42 ` Alex Kost [this message]
[not found] ` <CAM5ENzCezyQd9xniEPrMTf9PCviqBcDwqKt+0OLR+5ybFXZgww@mail.gmail.com>
2016-04-10 7:42 ` Alex Kost
2016-05-31 20:41 ` Mckinley Olsen
2016-06-01 13:30 ` 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpo7rx5g.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=mck.olsen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.