From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/5] gnu: Add avr-binutils.
Date: Thu, 14 Apr 2016 19:04:08 +0200
Message-ID: <87wpo0ktpz.fsf@gnu.org>
References: <1460639824-9976-1-git-send-email-dthompson2@worcester.edu>
	<1460639824-9976-2-git-send-email-dthompson2@worcester.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35900)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aqkgg-0000Bi-P0
	for guix-devel@gnu.org; Thu, 14 Apr 2016 13:04:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aqkgd-0003FK-JF
	for guix-devel@gnu.org; Thu, 14 Apr 2016 13:04:14 -0400
In-Reply-To: <1460639824-9976-2-git-send-email-dthompson2@worcester.edu>
	(David Thompson's message of "Thu, 14 Apr 2016 09:17:00 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> * gnu/packages/avr.scm (avr-binutils): New variable.

[...]

> +(define-public avr-binutils
> +  (package
> +    (inherit (cross-binutils "avr"))
> +    (name "avr-binutils")
> +    (arguments
> +     '(#:configure-flags '("--target=3Davr"
> +                           "--disable-nls")))))

AFAICS --target=3Davr is redundant:

--8<---------------cut here---------------start------------->8---
$ git describe
v0.10.0-204-ga2d0e20
$ wget -q -O - $(./pre-inst-env guix build --log-file -e '((@ (gnu packages=
 cross-base) cross-binutils) "avr")') |grep -e --target
configure flags: ("CONFIG_SHELL=3D/gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744=
j2-bash-4.3.42/bin/bash" "SHELL=3D/gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744=
j2-bash-4.3.42/bin/bash" "--prefix=3D/gnu/store/gqmq8gis9igpg4xy6022mvq8qpv=
p7kk4-binutils-cross-avr-2.25.1" "--enable-fast-install" "--build=3Dx86_64-=
unknown-linux-gnu" "--target=3Davr" "--with-sysroot=3D/" "LDFLAGS=3D-static=
-libgcc" "--with-lib-path=3D/no-ld-lib-path" "--disable-werror" "--enable-i=
nstall-libbfd" "--enable-deterministic-archives")
--8<---------------cut here---------------end--------------->8---

=E2=80=A6 and --disable-nls is orthogonal and probably unnecessary.

Can we skip this patch?  :-)

Ludo=E2=80=99.