From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: services: Add mysql-service.
Date: Thu, 16 Jun 2016 12:58:55 +0200
Message-ID: <87wplph028.fsf@gnu.org>
References: <1465913611-5552-1-git-send-email-iyzsong@gmail.com>
	<87r3byegyt.fsf@gnu.org> <87h9cuijkm.fsf@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50363)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bDV0p-0000Gy-Nq
	for guix-devel@gnu.org; Thu, 16 Jun 2016 06:59:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bDV0m-0000Cw-2B
	for guix-devel@gnu.org; Thu, 16 Jun 2016 06:59:02 -0400
In-Reply-To: <87h9cuijkm.fsf@member.fsf.org> (=?utf-8?B?IuWui+aWh+atpiIn?=
	=?utf-8?B?cw==?= message of "Wed, 15 Jun 2016 22:59:53 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@member.fsf.org>
Cc: guix-devel@gnu.org

iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>
>> Hello!
>>
>> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

[...]

>>> +@deftp {Data Type} mysql-configuration
>>> +Data type representing the configuration of @var{mysql-service}.
>>> +
>>> +@table @asis
>>> +@item @code{mysql} (default: @var{mariadb})
>>> +Package object of the MySQL database server, can be either @var{mariad=
b}
>>> +or @var{mysql}.
>>> +@end table
>>> +@end deftp
>>
>> Do you have plans to extend this type eventually?
> Not yet, should I use a simple keywoard argument instead?

No, that=E2=80=99s fine, just wondering.

>>> +(define (%mysql-activation config)
>>
>> Please add a docstring.  IIUC it initializes the =E2=80=98mysql=E2=80=99=
 database for
>> user =E2=80=98mysql=E2=80=99, and that database contains configuration i=
nfo, right?
> Yes, it does what =E2=80=98mysql_install_db=E2=80=99 and =E2=80=98mysql_s=
ecure_installation=E2=80=99
> do (which doesn=E2=80=99t work directly now due to missing coreutils, etc.
> in PATH).

OK, would be worth mentioning in a comment.

> And now I realize that this doesn't work for mysql,
> I need to rename this to =E2=80=98%mariadb-activation=E2=80=99 and write
> another =E2=80=98%mysql-activation=E2=80=99.

Oh, then maybe an additional configuration knob is needed to choose
between MariaDB and MySQL?

Thanks,
Ludo=E2=80=99.