From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: not a patch.. yet. git-daemon-service
Date: Mon, 04 Jul 2016 10:31:25 +0200
Message-ID: <87wpl1g5ya.fsf@gnu.org>
References: <20160617231045.GA4910@khazad-dum> <874m8o6zbd.fsf@gnu.org>
	<87mvlx26s2.fsf@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48174)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bJzHw-0005k3-Hf
	for guix-devel@gnu.org; Mon, 04 Jul 2016 04:31:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bJzHt-00074N-Bw
	for guix-devel@gnu.org; Mon, 04 Jul 2016 04:31:32 -0400
In-Reply-To: <87mvlx26s2.fsf@we.make.ritual.n0.is> (ng0@we.make.ritual.n0.is's
	message of "Mon, 04 Jul 2016 07:37:17 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org

ng0 <ng0@we.make.ritual.n0.is> skribis:

> Ludovic Court=C3=A8s writes:
>
>> ng0 <ng0@we.make.ritual.n0.is> skribis:
>>
>>>> (define-record-type* <git-daemon-configuration>
>>>>   git-daemon-configuration make-git-daemon-configuration
>>>>   git-daemon-configuration?
>>>>   (git-daemon     git-daemon-configuration-git
>>>>                   (default git))
>>>>   (base-path      git-daemon-configuration-base-path) ; string
>>>>   (port           git-daemon-configuration-port) ; string (default: 94=
18)
>>>>   (extra-settings git-daemon-configuration-extra-settings))
>>>>   ;;(export-all              git-daemon-configuration-export-all?) ;; =
those are switches I need to add differently
>>>>   ;;(informative-errors      git-daemon-configuration-informative-erro=
rs?) ;; same.
>>>>   ;;(verbose                 git-daemon-configuration-verbose?)) ;; sa=
me.
>>>
>>> There are many settings. The ones I think are the very basic ones which=
 can
>>> be used for a start for this service are:
>>> port, base-path, a forced --syslog --informative-errors and finally the=
 option
>>> to add whatever you want to add when you read the man page.
>>> There are more we can add later, but those are the very basic in my opi=
nion.
>>> What's your opinion?
>>
>> I think it=E2=80=99s OK to restrict yourself to the most common options =
at
>> first.  We can always add more options eventually.
>>
>> Thanks for working on it!
>>
>> Ludo=E2=80=99.
>
> How would I test run this service?

You can test it manually by creating an OS config that uses it and
instantiating it in a VM, with =E2=80=98guix system vm=E2=80=99.  In the VM=
 you can
check whether git-daemon is running and working as expected.

Writing an automated test would be very valuable, but it=E2=80=99s a bit mo=
re
work.  The (gnu tests base) module has examples, and
<https://savannah.gnu.org/forum/forum.php?forum_id=3D8605> gives an
overview.

HTH!

Ludo=E2=80=99.