From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/3] gnu: Add arm-none-eabi cross compiler.
Date: Wed, 21 Sep 2016 17:34:54 +0900
Message-ID: <87wpi5lkgh.fsf@gnu.org>
References: <20160918063513.11027-1-rekado@elephly.net>
	<20160918063513.11027-2-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58755)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bmiqq-0007g6-9Z
	for guix-devel@gnu.org; Wed, 21 Sep 2016 10:50:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bmiqm-0005Sk-HW
	for guix-devel@gnu.org; Wed, 21 Sep 2016 10:50:20 -0400
In-Reply-To: <20160918063513.11027-2-rekado@elephly.net> (Ricardo Wurmus's
	message of "Sun, 18 Sep 2016 08:35:11 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Hi!

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/bootstrap.scm (glibc-dynamic-linker): Add case for "arm-ea=
bi".
> * gnu/packages/embedded.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

[...]

> +;; Commit hashes and SVN revisions for xbinutils and xgcc are taken
> +;; from https://launchpadlibrarian.net/209776344/release.txt
> +
> +(define-public xbinutils-arm-none-eabi

[...]

> +      (arguments
> +       `(,@(substitute-keyword-arguments (package-arguments parent)
> +             ((#:configure-flags flags)
> +              `(cons "--enable-multilib"
> +                     (delete "--disable-multilib" ,flags)))))))))

Why is multilib support needed?  Could you add a comment here?

Also, `,@lst is equivalent to lst.  :-)

> +       `(,@(substitute-keyword-arguments (package-arguments xgcc)
            ^^
Same here.

> +             ((#:configure-flags flags)
> +              `(append (list "--enable-multilib"
> +                             "--with-newlib"
> +                             "--with-multilib-list=3Darmv6-m,armv7-m,arm=
v7e-m"
> +                             "--with-host-libstdcxx=3D-static-libgcc -Wl=
,-Bstatic,-lstdc++,-Bdynamic -lm"
> +                             "--enable-plugins"
> +                             "--disable-decimal-float"
> +                             "--disable-libffi"
> +                             "--disable-libgomp"
> +                             "--disable-libmudflap"
> +                             "--disable-libquadmath"
> +                             "--disable-libssp"
> +                             "--disable-libstdcxx-pch"
> +                             "--disable-nls"
> +                             "--disable-shared"
> +                             "--disable-threads"
> +                             "--disable-tls"
> +                             "--with-gnu-as"
> +                             "--with-gnu-ld")
> +                       (delete "--disable-multilib" ,flags)))))))))

Could you add comments explaining briefly where these flags come from?
Normally --with-gnu-* are not needed because ./configure should detect
that.

Thank you,
Ludo=E2=80=99.