From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 00/14] Change python-build-system (fixes bug 20765) Date: Sun, 02 Oct 2016 16:24:27 +0200 Message-ID: <87wphqesmc.fsf@gnu.org> References: <1475071107-10765-1-git-send-email-h.goebel@crazy-compilers.com> <57EBCD98.9020407@goebel-consult.de> <87mvism34v.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <57EC008A.4030006@crazy-compilers.com> <87bmz5ih9u.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqhh1-0007ui-L3 for guix-devel@gnu.org; Sun, 02 Oct 2016 10:24:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqhgw-0000lC-Kc for guix-devel@gnu.org; Sun, 02 Oct 2016 10:24:38 -0400 In-Reply-To: <87bmz5ih9u.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Fri, 30 Sep 2016 15:39:09 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Hi! Marius Bakke skribis: > Hartmut Goebel writes: > >> Am 28.09.2016 um 17:54 schrieb Marius Bakke: >>> Or push a branch somewhere? >> >> Branch is now available at=20 >> > > Thanks a lot for doing this! > > After adding a couple of patches I'm able to build many python packages. > Patch #2 mostly emulates NixOS "shim" setup.py[0], required for packages > using distutils instead of setuptools. > > Some packages really don't like the new configure flags however (scons). > Perhaps we should have them as default, but if #:configure-flags is set, > let them be overridden? In general it seems like a good pattern. > Also some packages are missing a dependency on "python-py"[1]. > > Perhaps we can set up a Hydra channel to deal with the fallout? I haven=E2=80=99t really followed, but if the two of you agree on that, tha= t=E2=80=99s definitely something we can do! > From a12000dd320cebeb920a4f790fe9206a2b6bda41 Mon Sep 17 00:00:00 2001 > From: Marius Bakke > Date: Thu, 29 Sep 2016 18:29:21 +0100 > Subject: [PATCH 1/2] guix: python-build-system: fix configure flag append > (followup to dba07a8d1) > > --- > guix/build/python-build-system.scm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Seems reasonable (with proper commit log). > From 84fa3e8be3d3d868ddb9278a96807086415b754d Mon Sep 17 00:00:00 2001 > From: Marius Bakke > Date: Thu, 29 Sep 2016 18:41:35 +0100 > Subject: [PATCH 2/2] guix: python-build-system: Import setuptools before > calling `setup.py'. > > This is needed for packages using "distutils" instead of "setuptools" > since the former does not understand the > "--single-version-externally-managed" flag. Also export __file__ since > it will be unset when setup.py is called from python "exec". Please move this explanation as a comment right above the newly-added code. > * guix/build/python-build-system.scm (call-setuppy): extend > "python setup.py" call to import setuptools, export __file__, and > call setup.py from setuptools python environment. It might be worth adding a comment on the general context in the code here. Regardless, it=E2=80=99s a good idea to get feedback from Hartmut and whoev= er else knows more about Python than myself before committing. :-) Speaking of which, could you create an account on savannah.gnu.org and send your account name to the folks marked as =E2=80=9Cproject admins=E2=80= =9D on ? Please send it as an OpenPGP-signed message, using the OpenPGP key that you will then use to sign commits. Also, make sure to upload said key to pgp.mit.edu and to add it on Savannah too. If anything is unclear, let me know. :-) TIA! Ludo=E2=80=99.