From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 2/4] gnu: notmuch: Enable tests. Date: Mon, 17 Oct 2016 19:56:32 +0100 Message-ID: <87wph67qjj.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> References: <20161017165506.17750-1-mbakke@fastmail.com> <20161017165506.17750-3-mbakke@fastmail.com> <20161017182912.GC31629@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwD5Z-0006zm-BT for guix-devel@gnu.org; Mon, 17 Oct 2016 14:56:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwD5W-0007Zp-71 for guix-devel@gnu.org; Mon, 17 Oct 2016 14:56:45 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33188) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwD5W-0007Zg-3B for guix-devel@gnu.org; Mon, 17 Oct 2016 14:56:42 -0400 In-Reply-To: <20161017182912.GC31629@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari writes: > On Mon, Oct 17, 2016 at 05:55:04PM +0100, Marius Bakke wrote: >> * gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch: New file. >> * gnu/local.mk (dist_patch_DATA): Register it. >> * gnu/packages/mail.scm (notmuch)[arguments]: Add verbose make flags. >> Add phase 'patch-notmuch-lib.el' to fix hard-coded /bin/sh. >> Add 'prepare-test-environment' phase to patch test shebangs and set >> environment. >> [native-inputs]: Change from 'emacs-minimal' to 'emacs-no-x'. Add dtach, >> gnupg, man, perl and which. > > A true nit-pick, but all those lines should start at column 0 rather > than being indented. Noted. > >> + (patches >> + ;; This is included in the next release. >> + ;; https://notmuchmail.org/pipermail/notmuch/2016/023309.html >> + (search-patches "notmuch-emacs-25-compatibility-fix.patch")))) > > Please mention the use of this patch in the commit changelog. Oops, thanks! > >> + ;; The following are required for tests only. >> + ("which" ,which) >> + ("dtach" ,dtach) >> + ("gnupg" ,gnupg) >> + ("man" ,man-db) >> + ("perl" ,perl))) > > Can you check if these inputs are referenced by the output? Ideally > not... > > $ guix gc --references $(./pre-inst-env guix build notmuch) Good point, I did not verify this until now. They are not referenced by the output. > >> diff --git a/gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch b/gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch >> new file mode 100644 >> index 0000000..456b345 >> --- /dev/null >> +++ b/gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch >> @@ -0,0 +1,43 @@ >> +From f575a346df09c82691bb9e7c462836d982fe31f7 Mon Sep 17 00:00:00 2001 >> +From: David Bremner >> +Date: Sun, 9 Oct 2016 19:30:44 -0300 >> +Subject: [PATCH] emacs/show: force notmuch-show-buttonise-links to act on >> + lines > > If possible, please add a hyperlink to the source of the patch. Ideally, > to a Git commit in a web-based Git repo interface. > > Not knowing Emacs Lisp, I can't comment on the patch itself. The bug was exposed by enabling tests against emacs 25 and will be included in the next release. See this thread: https://notmuchmail.org/pipermail/notmuch/2016/023227.html I will add a gitweb link to the patch header.