From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: Re: [PATCH 4/5] install: Extract procedure: install-grub-config. Date: Sun, 06 Nov 2016 17:25:51 -0800 Message-ID: <87wpggnkrk.fsf@gmail.com> References: <87d1ihscmr.fsf@gnu.org> <20161102054815.11253-1-cmmarusich@gmail.com> <20161102054815.11253-5-cmmarusich@gmail.com> <20161106220001.1ca62b07@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3YhC-0007Sl-K3 for guix-devel@gnu.org; Sun, 06 Nov 2016 20:25:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3YhB-000470-Hp for guix-devel@gnu.org; Sun, 06 Nov 2016 20:25:58 -0500 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:34869) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c3YhB-00046V-AY for guix-devel@gnu.org; Sun, 06 Nov 2016 20:25:57 -0500 Received: by mail-pf0-x242.google.com with SMTP id i88so14571626pfk.2 for ; Sun, 06 Nov 2016 17:25:56 -0800 (PST) In-Reply-To: <20161106220001.1ca62b07@scratchpost.org> (Danny Milosavljevic's message of "Sun, 6 Nov 2016 22:00:01 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Danny Milosavljevic writes: > Thanks for this! > >> -(define* (install-grub grub.cfg device mount-point) >> +(define (install-grub grub.cfg device mount-point) >> "Install GRUB with GRUB.CFG on DEVICE, which is assumed to be mounted= on >> MOUNT-POINT. >>=20=20 >> Note that the caller must make sure that GRUB.CFG is registered as a GC= root >> so that the fonts, background images, etc. referred to by GRUB.CFG are = not >> GC'd." >> + (install-grub-config grub.cfg mount-point) >> + (unless (zero? (system* "grub-install" "--no-floppy" > > ^^^ since you have touched it, maybe you know: How does it know which pac= kage's (which directory's) grub-install to invoke here? There is logic in the perform-action procedure in (guix scripts system) which adds GRUB to the PATH environment variable. That's where the determination occurs. So, currently, it looks like the 'grub-install' command comes from whatever version of grub happens to be defined in (gnu packages grub) at the time perform-action gets called. In practice, I believe this means that whatever grub version is currently available in guix (e.g., as seen via 'guix package --show=3Dgrub') will be used. Hope that helps! =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYH9gfAAoJEN1AmhXYIkadltkQAKGBIlRWVvVRGmz/jZUV8LpU L4P4W8e9gXc9MzRw8urYomTO/FXD5GKRvahPOTicGX0t9o/r7/5+dBS5VD5IW8J8 CiLCikQ4t47XlDtMvDP7rP9MYkdZMB3Rl4AxXSPgqWWg+i+P11ZELZNG8Q5aZHfY 3Oh+O2S+O+l/c4fKxltZZBYeXwi3afede8z/bE/nSqTZWWFJl3DZ5KoulXhrKEkb dhg3520gfSSorLMBKFEwmUYfumkE1TbOJJqXz74ynd51nUX4rJDxNQO6fbVdHlWw xPaAWDbm466kP4QgBwOdHc5uM0uQIfWOvYZ/TLa1sIDYskVvMBnr7pgtnJsmeH26 XCqV3rKRi0Rgi5saj/kc+x2NxQYCn60DE2kt6M/9eZmjdlC5zloBZOCHwh+LOgLx qNNJs4Yb1sMBSXK6o98d/6JLTpFqbcgn+aG3lkOwuNXiyrYV0Ba4ymanEgh+9i9l CFXBsZResylEaWRHyVHfiZ5Qp+uO4bbFjIq4qivNKYvBp7r50G6k4rBZvDhVjWl1 Cu61qf30jWmSkVg+mLjbW4HyPR8eYmrpqisMDF3yZ7r1P6/zlCs37OmodfDoY4Ju ze1hVnWGVYEVupuYq+zEEtmdMl7Ha2eA3h5CpLGqEQXjtxV3qKZpU0BCwacIX6GO Lwo1EFGTgJyOcXks2/LX =+5UL -----END PGP SIGNATURE----- --=-=-=--