From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Explicitly pass grub to install, install-grub*, install-grub, initialize-hard-disk and qemu-image. Date: Thu, 10 Nov 2016 18:09:40 +0100 Message-ID: <87wpgbqn1n.fsf@gnu.org> References: <20161110090927.13187-1-dannym@scratchpost.org> <871syjbcku.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4srC-0001n7-IM for guix-devel@gnu.org; Thu, 10 Nov 2016 12:09:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4sr9-0002Cu-Et for guix-devel@gnu.org; Thu, 10 Nov 2016 12:09:46 -0500 In-Reply-To: <871syjbcku.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Thu, 10 Nov 2016 15:04:49 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Hello! Marius Bakke skribis: > Thanks for this patch! I have verified that it works both for `guix > system vm-image` and on my grub-efi system. > > Do you think this eliminates the need for the "setenv PATH" trick in > guix/scripts/system.scm:648? For the record, I tested the patch with > that section removed as well, making sure there was no grub-install in > my PATH. I prefer that setting PATH to point to the right GRUB, rather than having to carry the directory name of GRUB in 10 different places. This is the approach taken in several places, such as (gnu system vm): we set PATH, and then we can happily call functions that in turn expect commands in $PATH. Danny, what led you to this patch? :-) Thanks, Ludo=E2=80=99.