all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Explicitly pass grub to install, install-grub*, install-grub, initialize-hard-disk and qemu-image.
Date: Thu, 10 Nov 2016 18:09:40 +0100	[thread overview]
Message-ID: <87wpgbqn1n.fsf@gnu.org> (raw)
In-Reply-To: <871syjbcku.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Thu, 10 Nov 2016 15:04:49 +0000")

Hello!

Marius Bakke <mbakke@fastmail.com> skribis:

> Thanks for this patch! I have verified that it works both for `guix
> system vm-image` and on my grub-efi system.
>
> Do you think this eliminates the need for the "setenv PATH" trick in
> guix/scripts/system.scm:648? For the record, I tested the patch with
> that section removed as well, making sure there was no grub-install in
> my PATH.

I prefer that setting PATH to point to the right GRUB, rather than
having to carry the directory name of GRUB in 10 different places.

This is the approach taken in several places, such as (gnu system vm):
we set PATH, and then we can happily call functions that in turn expect
commands in $PATH.

Danny, what led you to this patch?  :-)

Thanks,
Ludo’.

  reply	other threads:[~2016-11-10 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10  9:09 [PATCH] Explicitly pass grub to install, install-grub*, install-grub, initialize-hard-disk and qemu-image Danny Milosavljevic
2016-11-10 15:04 ` Marius Bakke
2016-11-10 17:09   ` Ludovic Courtès [this message]
2016-11-11 15:12     ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpgbqn1n.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.