From: ludo@gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] guix: Add whitespacing to --list-generations output.
Date: Thu, 17 Nov 2016 13:28:12 +0100 [thread overview]
Message-ID: <87wpg247fn.fsf@gnu.org> (raw)
In-Reply-To: <20161117092413.GB24482@macbook42.flashner.co.il> (Efraim Flashner's message of "Thu, 17 Nov 2016 11:24:14 +0200")
Efraim Flashner <efraim@flashner.co.il> skribis:
> On Thu, Nov 17, 2016 at 09:59:55AM +0100, Roel Janssen wrote:
>> Dear Guix,
>>
>> The new diff-format displayed when invoking @command{guix package
>> --list-generations} prints a blank line after the initial generation,
>> and then no blank lines in the diffs.
>>
>> This patch adds that blank line to the diffs as well.
>>
>> Before:
>> ------------------------------------------------------------------------------
>> Generation 1 Nov 15 2016 11:14:05
>> guix 0.10.0-1.97c8 out /gnu/store/5ibkqq9...-guix-0.10.0-1.97c8
>>
>> Generation 2 Nov 15 2016 12:06:32
>> + emacs 25.1 out /gnu/store/sb2qfjr...-emacs-25.1
>> Generation 4 Nov 15 2016 12:22:15
>> + guix 0.11.0-3.7ca3 out /gnu/store/l99rkv2...-guix-0.11.0-3.7ca3
>> - guix 0.10.0-1.97c8 out /gnu/store/5ibkqq9...-guix-0.10.0-1.97c8
>> ------------------------------------------------------------------------------
>>
>> After:
>> ------------------------------------------------------------------------------
>> Generation 1 Nov 15 2016 11:14:05
>> guix 0.10.0-1.97c8 out /gnu/store/5ibkqq9...-guix-0.10.0-1.97c8
>>
>> Generation 2 Nov 15 2016 12:06:32
>> + emacs 25.1 out /gnu/store/sb2qfjr...-emacs-25.1
>>
>> Generation 4 Nov 15 2016 12:22:15
>> + guix 0.11.0-3.7ca3 out /gnu/store/l99rkv2...-guix-0.11.0-3.7ca3
>> - guix 0.10.0-1.97c8 out /gnu/store/5ibkqq9...-guix-0.10.0-1.97c8
>> ------------------------------------------------------------------------------
>>
>> As you can see, it's only a small change, and so is the code change.
>> Here's the patch:
>>
>> >From a9b5305f8af51b88643986f99a8e94cad4d7a805 Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Thu, 17 Nov 2016 09:46:15 +0100
>> Subject: [PATCH] guix: Add whitespacing to --list-generations output.
>>
>> ---
>> guix/ui.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/guix/ui.scm b/guix/ui.scm
>> index b9fbbfd..cafb3c6 100644
>> --- a/guix/ui.scm
>> +++ b/guix/ui.scm
>> @@ -1094,7 +1094,8 @@ DURATION-RELATION with the current time."
>> (removed (lset-difference
>> equal-entry? (list-entries old) (list-entries new))))
>> (for-each (cut display-entry <> "+") added)
>> - (for-each (cut display-entry <> "-") removed)))
>> + (for-each (cut display-entry <> "-") removed)
>> + (newline)))
>>
>> (display-diff profile gen1 gen2))
>>
>> --
>> 2.7.4
>>
>> Kind regards,
>> Roel Janssen
>>
>
> That does make it easier to read
+1!
Ludo'.
prev parent reply other threads:[~2016-11-17 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 8:59 [PATCH] guix: Add whitespacing to --list-generations output Roel Janssen
2016-11-17 9:24 ` Efraim Flashner
2016-11-17 12:28 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpg247fn.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.