all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] gnu: Add ruby-hashie
@ 2016-11-21 15:23 Frederick Muriithi
  2016-11-21 18:04 ` Marius Bakke
  0 siblings, 1 reply; 2+ messages in thread
From: Frederick Muriithi @ 2016-11-21 15:23 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Added new variable ruby-hashie

Tests deactivated, since the gem seems to not have the Gemfile
present, leading to failure.
Checking out the repository manually and running rake in it, runs all
tests successfully.

If this is not acceptable, please let me know, and any pointers to
correct the issues would be appreciated.

-- 
Frederick M. Muriithi

[-- Attachment #2: 0001-gnu-Add-ruby-hashie.patch --]
[-- Type: text/x-patch, Size: 1599 bytes --]

From aaefbb774a2c0aac4d80ca686bd4b3fbc55ccb1d Mon Sep 17 00:00:00 2001
From: Muriithi Frederick Muriuki <fredmanglis@gmail.com>
Date: Mon, 21 Nov 2016 18:12:18 +0300
Subject: [PATCH] gnu: Add ruby-hashie.

* gnu/packages/ruby.scm (ruby-hashie): New variable.
---
 gnu/packages/ruby.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 1abea02..d8c36be 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -4221,3 +4221,29 @@ RFC 2617.  This enables the use of the digest authentication scheme instead
 of the more insecure basic authentication scheme.")
     (home-page "http://github.com/drbrain/net-http-digest_auth")
     (license license:expat)))
+
+(define-public ruby-hashie
+   (package
+   (name "ruby-hashie")
+   (version "3.4.6")
+   (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "hashie" version))
+       (sha256
+         (base32
+           "1ny9z0lr8hszx2y2cb07sd6iwvhs9lphl1sqr2vs7bjf7mx8pbcj"))))
+   (build-system ruby-build-system)
+   (arguments
+    ;; Gemfile present in repo, but missing in gem causing test failure during build
+    `(#:tests? #f))
+   (native-inputs
+    `(("bundler" ,bundler)
+      ("ruby-rspec-core" ,ruby-rspec-core)))
+   (synopsis
+     "Hashie is a collection of classes and mixins that make hashes more powerful")
+   (description
+    "Hashie is a growing collection of tools that extend Hashes and make
+them more powerful")
+   (home-page "https://github.com/intridea/hashie")
+   (license license:expat)))
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gnu: Add ruby-hashie
  2016-11-21 15:23 [PATCH] gnu: Add ruby-hashie Frederick Muriithi
@ 2016-11-21 18:04 ` Marius Bakke
  0 siblings, 0 replies; 2+ messages in thread
From: Marius Bakke @ 2016-11-21 18:04 UTC (permalink / raw)
  To: Frederick Muriithi, guix-devel

[-- Attachment #1: Type: text/plain, Size: 2435 bytes --]

Frederick Muriithi <fredmanglis@gmail.com> writes:

> Added new variable ruby-hashie
>
> Tests deactivated, since the gem seems to not have the Gemfile
> present, leading to failure.
> Checking out the repository manually and running rake in it, runs all
> tests successfully.
>
> If this is not acceptable, please let me know, and any pointers to
> correct the issues would be appreciated.

I've come across similar problems in some python packages, where the
pypi release does not have tests enabled. In those cases I think it's
acceptable to package the git snapshots, assuming they are properly
tagged with version. Could you try that? Thanks!

>
> -- 
> Frederick M. Muriithi
> From aaefbb774a2c0aac4d80ca686bd4b3fbc55ccb1d Mon Sep 17 00:00:00 2001
> From: Muriithi Frederick Muriuki <fredmanglis@gmail.com>
> Date: Mon, 21 Nov 2016 18:12:18 +0300
> Subject: [PATCH] gnu: Add ruby-hashie.
>
> * gnu/packages/ruby.scm (ruby-hashie): New variable.
> ---
>  gnu/packages/ruby.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 1abea02..d8c36be 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -4221,3 +4221,29 @@ RFC 2617.  This enables the use of the digest authentication scheme instead
>  of the more insecure basic authentication scheme.")
>      (home-page "http://github.com/drbrain/net-http-digest_auth")
>      (license license:expat)))
> +
> +(define-public ruby-hashie
> +   (package
> +   (name "ruby-hashie")
> +   (version "3.4.6")
> +   (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "hashie" version))
> +       (sha256
> +         (base32
> +           "1ny9z0lr8hszx2y2cb07sd6iwvhs9lphl1sqr2vs7bjf7mx8pbcj"))))
> +   (build-system ruby-build-system)
> +   (arguments
> +    ;; Gemfile present in repo, but missing in gem causing test failure during build
> +    `(#:tests? #f))
> +   (native-inputs
> +    `(("bundler" ,bundler)
> +      ("ruby-rspec-core" ,ruby-rspec-core)))
> +   (synopsis
> +     "Hashie is a collection of classes and mixins that make hashes more powerful")
> +   (description
> +    "Hashie is a growing collection of tools that extend Hashes and make
> +them more powerful")
> +   (home-page "https://github.com/intridea/hashie")
> +   (license license:expat)))
> -- 
> 2.1.4

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-21 18:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-21 15:23 [PATCH] gnu: Add ruby-hashie Frederick Muriithi
2016-11-21 18:04 ` Marius Bakke

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.