From: Kei Kebreau <kei@openmailbox.org>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/3] gnu: Add xdot.
Date: Sun, 27 Nov 2016 16:55:47 -0500 [thread overview]
Message-ID: <87wpfofuzg.fsf@openmailbox.org> (raw)
In-Reply-To: <20161126142758.25457-2-theodoros.for@openmailbox.org> (Theodoros Foradis's message of "Sat, 26 Nov 2016 16:27:56 +0200")
[-- Attachment #1: Type: text/plain, Size: 4162 bytes --]
Theodoros Foradis <theodoros.for@openmailbox.org> writes:
> * gnu/packages/graphviz.scm (xdot): New variable.
> ---
> gnu/packages/graphviz.scm | 52 ++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 51 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/graphviz.scm b/gnu/packages/graphviz.scm
> index 610bd16..a336183 100644
> --- a/gnu/packages/graphviz.scm
> +++ b/gnu/packages/graphviz.scm
> @@ -1,6 +1,7 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2013, 2015 Ludovic Courtès <ludo@gnu.org>
> ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
> +;;; Copyright © 2016 Theodoros Foradis <theodoros.for@openmailbox.org>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -20,6 +21,7 @@
> (define-module (gnu packages graphviz)
> #:use-module (guix packages)
> #:use-module (guix build-system gnu)
> + #:use-module (guix build-system python)
> #:use-module (guix download)
> #:use-module (gnu packages xorg)
> #:use-module (gnu packages gtk)
> @@ -30,11 +32,14 @@
> #:use-module (gnu packages image)
> #:use-module (gnu packages autotools)
> #:use-module (gnu packages pkg-config)
> + #:use-module (gnu packages glib)
> + #:use-module (gnu packages gtk)
> + #:use-module (gnu packages gnome)
> #:use-module (gnu packages fontutils)
> #:use-module (gnu packages compression)
> #:use-module (gnu packages gd)
> #:use-module (gnu packages swig)
> - #:use-module ((guix licenses) #:select (lgpl2.0+ epl1.0)))
> + #:use-module ((guix licenses) #:select (lgpl2.0+ epl1.0 lgpl3+)))
>
> (define-public graphviz
> (package
> @@ -148,3 +153,48 @@ interfaces for other technical domains.")
> "Library intended to provide a set of useful functions to deal with
> 3D surfaces meshed with interconnected triangles.")
> (license lgpl2.0+)))
> +
> +(define-public xdot
> + (package
> + (name "xdot")
> + (version "0.7")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "xdot" version))
> + (sha256
> + (base32
> + "1q0f3pskb09saw1qkd2s6vmk80rq5zjhq8l93dfr2x6r04r0q46j"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + ;; We wrap xdot, so that we don't propagate gtk+ and graphviz
> + (add-after 'install 'wrap
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (wrap-program (string-append (assoc-ref outputs "out") "/bin/xdot")
> + `("GI_TYPELIB_PATH" ":" prefix
> + (,(string-append
> + (assoc-ref inputs "gtk+") "/lib/girepository-1.0"
> + ":" (assoc-ref inputs "pango") "/lib/girepository-1.0"
> + ":" (assoc-ref inputs "gdk-pixbuf") "/lib/girepository-1.0"
> + ":" (assoc-ref inputs "atk") "/lib/girepository-1.0")))
> + `("PATH" ":" prefix
> + (,(string-append (assoc-ref inputs "graphviz") "/bin"))))
> + #t)))))
Adding #:configure-flags '("--single-version-externally-managed"
"--root=/") to the arguments list makes xdot's handling of the .egg
files reproducible.
> + (inputs
> + `(("atk" ,atk)
> + ("gdk-pixbuf" ,gdk-pixbuf+svg)
> + ("graphviz" ,graphviz)
> + ("gtk+" ,gtk+)
> + ("python-pycairo" ,python-pycairo)
> + ("python-pygobject" ,python-pygobject)))
> + (home-page "https://pypi.python.org/pypi/xdot")
> + (synopsis
> + "Interactive viewer for graphviz dot files")
> + (description
> + "Xdot is an interactive viewer for graphs written in @code{graphviz}’s dot language.
> + It uses internally the xdot output format as an intermediate format,and @code{gtk} and
> +@code{cairo} for rendering. Xdot can be used either as a standalone application, or as
> +a python library.")
> + (license lgpl3+)))
Other than the comment above, LGTM. Is there someone more experienced
with Python packages who can double check this?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2016-11-27 21:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-26 14:27 [PATCH 0/3] Add xdot and update yosys Theodoros Foradis
2016-11-26 14:27 ` [PATCH 1/3] gnu: Add xdot Theodoros Foradis
2016-11-27 21:55 ` Kei Kebreau [this message]
2016-12-09 14:21 ` Ludovic Courtès
2017-01-01 18:44 ` Theodoros Foradis
2017-01-02 1:09 ` Leo Famulari
2016-11-26 14:27 ` [PATCH 2/3] gnu: yosys: Add xdot functionality Theodoros Foradis
2016-11-29 0:25 ` Danny Milosavljevic
2016-11-26 14:27 ` [PATCH 3/3] gnu: yosys: Update to 0.7 Theodoros Foradis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpfofuzg.fsf@openmailbox.org \
--to=kei@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=theodoros.for@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.