[PATCH] gnu: Add ghc-flac.

[PATCH] gnu: Add ghc-flac.

[Danny Milosavljevic]

* gnu/packages/haskell.scm (ghc-flac): New variable.
---
 gnu/packages/haskell.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index b26234d40..b2ee11b2a 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -43,6 +43,7 @@
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages sdl)
+  #:use-module (gnu packages xiph)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (gnu packages zip)
@@ -8162,4 +8163,37 @@ Rust syntax.  It is intended to be useful for two different purposes:
 files in Haskell.")
     (license license:bsd-3)))
 
+(define-public ghc-flac
+  (package
+    (name "ghc-flac")
+    (version "0.1.1")
+    (source (origin
+      (method url-fetch)
+      (uri (string-append
+             "https://hackage.haskell.org/package/flac/flac-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "0gl707qcxyzc8cbqsajhxm7j648iv23mpfdayyfc7pwvndy2idsq"))))
+    (build-system haskell-build-system)
+    (inputs
+     `(("ghc-data-default-class"
+        ,ghc-data-default-class)
+       ("ghc-exceptions" ,ghc-exceptions)
+      ("ghc-mtl" ,ghc-mtl)
+       ("ghc-text" ,ghc-text)
+       ("ghc-vector" ,ghc-vector)
+       ("ghc-wave" ,ghc-wave)
+       ("ghc-semigroups" ,ghc-semigroups)
+       ("ghc-temporary" ,ghc-temporary)
+       ("flac" ,flac)))
+    (native-inputs
+     `(("ghc-hspec" ,ghc-hspec)
+       ("hspec-discover" ,hspec-discover)))
+    (home-page "https://github.com/mrkkrp/flac")
+    (synopsis "Haskell binding to libFLAC")
+    (description "Complete high-level binding to libFLAC for Haskell.")
+    (license license:bsd-3)))
+
 ;;; haskell.scm ends here

Re: [PATCH] gnu: Add ghc-flac.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/haskell.scm (ghc-flac): New variable.

Cool!

[...]

> +    (native-inputs
> +     `(("ghc-hspec" ,ghc-hspec)
> +       ("hspec-discover" ,hspec-discover)))

Are these referenced by the built product? If so, they should be in
[inputs]. You can check references with `guix gc -R`, or try something
like `guix graph -t references ghc-flac | dot -T png | feh -` for a tree
view. Or grep the store paths for a "shotgun" approach :-)

The indentation is off some places, but otherwise this LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: [PATCH] gnu: Add ghc-flac.

[Ludovic Courtès]

Hi Danny,

To complement Marius’ review…

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> +    (description "Complete high-level binding to libFLAC for Haskell.")

Please make it a complete sentence, and sort-of hint at what libFLAC
along these lines:

  This package provides a Haskell interface to libFLAC, the Free
  Lossless Audio Codec (FLAC) decoding library.

Otherwise LGTM.  :-)

Ludo’.