From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add ghc-flac. Date: Mon, 16 Jan 2017 01:19:51 +0100 Message-ID: <87wpdvx3dk.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20170115231015.3893-1-dannym@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cSv1i-0006PU-0o for guix-devel@gnu.org; Sun, 15 Jan 2017 19:19:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cSv1e-0000Ar-Ok for guix-devel@gnu.org; Sun, 15 Jan 2017 19:19:57 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:57654) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cSv1e-0000Af-IG for guix-devel@gnu.org; Sun, 15 Jan 2017 19:19:54 -0500 In-Reply-To: <20170115231015.3893-1-dannym@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic , guix-devel@gnu.org --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > * gnu/packages/haskell.scm (ghc-flac): New variable. Cool! [...] > + (native-inputs > + `(("ghc-hspec" ,ghc-hspec) > + ("hspec-discover" ,hspec-discover))) Are these referenced by the built product? If so, they should be in [inputs]. You can check references with `guix gc -R`, or try something like `guix graph -t references ghc-flac | dot -T png | feh -` for a tree view. Or grep the store paths for a "shotgun" approach :-) The indentation is off some places, but otherwise this LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlh8EacACgkQoqBt8qM6 VPrlRwf+NqvDpLpyJWVkeIgiGH5vvEKMfsDrcjp0oDYwwKqOYqA03df0X0BlWuqh FxGHSzfHOdx0En5n/hWJV81vUOAcAT9riVpBTKLiTDjHkpywX5b6SDTxWS2L7G/8 vQh4PUd887LM6Kv1MXHt+Zpz5nU8hP3m5BxZHFIqEpC2PLrMIq7Vhg5j5FnoakpE fjQy/bPH0JWHqlmvbmNCz2UCevV/ZQXrqwANAYQZn9t+sdu+0gJbPkmy+8Z1Okf2 fIE8FcEankWZjGprcz2IeNB2A3leBgLAd6JBZEbay2oWb1aubFlc6ENcQkwKfl1N mfTdl8iMrPVH+us93OC1Y+jIh2jSpA== =8fPD -----END PGP SIGNATURE----- --=-=-=--