From: Marius Bakke <mbakke@fastmail.com>
To: Danny Milosavljevic <dannym@scratchpost.org>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add ghc-flac.
Date: Mon, 16 Jan 2017 01:19:51 +0100 [thread overview]
Message-ID: <87wpdvx3dk.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20170115231015.3893-1-dannym@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
Danny Milosavljevic <dannym@scratchpost.org> writes:
> * gnu/packages/haskell.scm (ghc-flac): New variable.
Cool!
[...]
> + (native-inputs
> + `(("ghc-hspec" ,ghc-hspec)
> + ("hspec-discover" ,hspec-discover)))
Are these referenced by the built product? If so, they should be in
[inputs]. You can check references with `guix gc -R`, or try something
like `guix graph -t references ghc-flac | dot -T png | feh -` for a tree
view. Or grep the store paths for a "shotgun" approach :-)
The indentation is off some places, but otherwise this LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-01-16 0:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-15 23:10 [PATCH] gnu: Add ghc-flac Danny Milosavljevic
2017-01-16 0:19 ` Marius Bakke [this message]
2017-01-16 10:01 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpdvx3dk.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.