From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add unetbootin.
Date: Thu, 19 Jan 2017 13:20:51 +0100
Message-ID: <87wpdrxmu4.fsf@gnu.org>
References: <871sw5ft93.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46644)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cUBiK-00057n-7g
	for guix-devel@gnu.org; Thu, 19 Jan 2017 07:21:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cUBiG-0006Vf-TU
	for guix-devel@gnu.org; Thu, 19 Jan 2017 07:21:12 -0500
In-Reply-To: <871sw5ft93.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Sat, 14
	Jan 2017 18:26:00 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Jan!

I=E2=80=99d suggest these minor cosmetic changes:


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index 71595bf3c..d922914e9 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -337,7 +337,8 @@ permit managing file systems not included in libparted.")
     (version "625")
     (source (origin
               (method url-fetch)
-              (uri (string-append "https://github.com/unetbootin/unetbootin/archive/"
+              (uri (string-append
+                    "https://github.com/unetbootin/unetbootin/archive/"
                     version ".tar.gz"))
               (file-name (string-append name "-" version ".tar.gz"))
               (sha256
@@ -353,18 +354,19 @@ permit managing file systems not included in libparted.")
              (chdir "src/unetbootin")
              (system* "lupdate" "unetbootin.pro")
              (system* "lrelease" "unetbootin.pro")
-             (system* "qmake")))
+             (zero? (system* "qmake"))))
          (replace 'install
            (lambda* (#:key outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))
                     (bin (string-append out "/bin")))
                (mkdir-p bin)
-                      (copy-file "unetbootin"
-                                 (string-append bin "/unetbootin"))))))))
+               (install-file "unetbootin" bin)
+               #t))))))
     (inputs
      `(("qt-4" ,qt-4)))
     (home-page "https://unetbootin.github.io/")
     (synopsis "Create bootable live USB images")
     (description
-     "UNetbootin creates bootable Live USB images.")
+     "UNetbootin allows you to create bootable USB images from ISO-9660 CD/DVD
+images.")
     (license license:gpl2+)))

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


In addition, there=E2=80=99s one thing we need to fix from an FSDG perspect=
ive,
which is described here:
<https://libreplanet.org/wiki/Software_blacklist#unetbootin>.

Could you check whether the package can be adjusted to use this FUSBi
fork mentioned there, and send an updated patch?

TIA!

Ludo=E2=80=99.


--=-=-=--