* gnu: add you-get
@ 2017-04-08 4:24 Feng Shu
2017-04-08 8:55 ` Catonano
0 siblings, 1 reply; 3+ messages in thread
From: Feng Shu @ 2017-04-08 4:24 UTC (permalink / raw)
To: guix-devel; +Cc: Feng Shu
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-add-you-get.patch --]
[-- Type: text/x-patch, Size: 1519 bytes --]
From fe6252c6fe9474078033bd3bffbd76b62f8449a8 Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Fri, 7 Apr 2017 21:18:55 +0800
Subject: [PATCH] gnu: add you-get
* gnu/packages/video.scm (you-get): New variable.
---
gnu/packages/video.scm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 4f005f594..1d1f4d10f 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1023,6 +1023,28 @@ YouTube.com and a few more sites.")
(home-page "https://yt-dl.org")
(license license:public-domain)))
+(define-public you-get
+ (package
+ (name "you-get")
+ (version "0.4.652")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/soimort/you-get/releases/download/v"
+ version "/you-get-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0brkz98lycx8mmxjwmn7jlhqfdbvl0hy070n7skwr1k75kh99q30"))))
+ (build-system python-build-system)
+ (arguments '(#:tests? #f))
+ (synopsis "Download videos, audios or images from the websites")
+ (description
+ "you-get is a tiny command-line utility, which can download media
+contents (videos, audios, images) from the Web, in case there is no other
+handy way to do it.")
+ (home-page "https://you-get.org/")
+ (license license:expat)))
+
(define-public libbluray
(package
(name "libbluray")
--
2.12.2
[-- Attachment #2: Type: text/plain, Size: 5 bytes --]
--
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: gnu: add you-get
2017-04-08 4:24 gnu: add you-get Feng Shu
@ 2017-04-08 8:55 ` Catonano
2017-04-08 8:57 ` Catonano
0 siblings, 1 reply; 3+ messages in thread
From: Catonano @ 2017-04-08 8:55 UTC (permalink / raw)
To: Feng Shu; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 2044 bytes --]
Hi Feng Shu,
Thanks or contributing to Guix !
This patch for you-download is almost good, just a few notes:
+(define-public you-get
+ (package
+ (name "you-get")
+ (version "0.4.652")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/soimort/you-get/releases/download/v"
+ version "/you-get-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0brkz98lycx8mmxjwmn7jlhqfdbvl0hy070n7skwr1k75kh99q30"))))
+ (build-system python-build-system)
+ (arguments '(#:tests? #f))
In the source code I can find no tests. But a comment about tests absence,
here, would be preferable.
Would you mind to add it ?
Also, on the home page of this project I see that Ffmpeg or libva are
dependencies but the are no inputs or propagated inputs in this package
definition
I didn't try to run this package but I suppose it won't run properly.
Am I wrong ?
+ (synopsis "Download videos, audios or images from the websites")
+ (description
+ "you-get is a tiny command-line utility, which can download media
+contents (videos, audios, images) from the Web, in case there is no other
+handy way to do it.")
+ (home-page "https://you-get.org/")
+ (license license:expat)))
I downloaded the tarball from git and the source files in the folder
"cli_wrapper" are empty.
Both Gedit and nano can read no lines
Some files have a size of 0
Others are extremely small
I don't know what this could be.
Can you confirm that instead they are correctly written ?
Or are they empty or you too ?
Also, you should add a line about copyright attribution to yourself.
At the beginning of the file there are many lines like this
;;; Copyright © 2017 humanitiesNerd <catonano@gmail.com>
You should add one or yourself.
As you can see, niknames are ok ;-)
Would you send a new patch with these suggestions integrated ?
Thanks and welcome !
[-- Attachment #2: Type: text/html, Size: 3417 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gnu: add you-get
2017-04-08 8:55 ` Catonano
@ 2017-04-08 8:57 ` Catonano
0 siblings, 0 replies; 3+ messages in thread
From: Catonano @ 2017-04-08 8:57 UTC (permalink / raw)
To: Feng Shu; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 2392 bytes --]
I forgot one last note !
Guix has a brand new issue tracker ! In the future would you send your
patches to
guix-patches@gnu.org ?
Thanks again !
2017-04-08 10:55 GMT+02:00 Catonano <catonano@gmail.com>:
> Hi Feng Shu,
>
> Thanks or contributing to Guix !
>
> This patch for you-download is almost good, just a few notes:
>
> +(define-public you-get
> + (package
> + (name "you-get")
> + (version "0.4.652")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/soimort/
> you-get/releases/download/v"
> + version "/you-get-" version ".tar.gz"))
> + (sha256
> + (base32
> + "0brkz98lycx8mmxjwmn7jlhqfdbvl0hy070n7skwr1k75kh99q30"))))
>
> + (build-system python-build-system)
> + (arguments '(#:tests? #f))
>
> In the source code I can find no tests. But a comment about tests absence,
> here, would be preferable.
>
> Would you mind to add it ?
>
> Also, on the home page of this project I see that Ffmpeg or libva are
> dependencies but the are no inputs or propagated inputs in this package
> definition
>
> I didn't try to run this package but I suppose it won't run properly.
> Am I wrong ?
>
> + (synopsis "Download videos, audios or images from the websites")
> + (description
> + "you-get is a tiny command-line utility, which can download media
> +contents (videos, audios, images) from the Web, in case there is no other
> +handy way to do it.")
> + (home-page "https://you-get.org/")
> + (license license:expat)))
>
> I downloaded the tarball from git and the source files in the folder
> "cli_wrapper" are empty.
>
> Both Gedit and nano can read no lines
>
> Some files have a size of 0
> Others are extremely small
>
> I don't know what this could be.
>
> Can you confirm that instead they are correctly written ?
>
> Or are they empty or you too ?
>
> Also, you should add a line about copyright attribution to yourself.
> At the beginning of the file there are many lines like this
>
> ;;; Copyright © 2017 humanitiesNerd <catonano@gmail.com>
>
> You should add one or yourself.
> As you can see, niknames are ok ;-)
>
> Would you send a new patch with these suggestions integrated ?
>
> Thanks and welcome !
>
>
>
[-- Attachment #2: Type: text/html, Size: 4083 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-08 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-08 4:24 gnu: add you-get Feng Shu
2017-04-08 8:55 ` Catonano
2017-04-08 8:57 ` Catonano
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.