From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59178)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cymUX-0002vl-WE
	for guix-patches@gnu.org; Thu, 13 Apr 2017 17:41:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cymUU-0006SP-TW
	for guix-patches@gnu.org; Thu, 13 Apr 2017 17:41:26 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:47992)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cymUA-0006QP-LI
	for guix-patches@gnu.org; Thu, 13 Apr 2017 17:41:22 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cymUA-0000EM-Ge
	for guix-patches@gnu.org; Thu, 13 Apr 2017 17:41:02 -0400
Subject: bug#26472: [PATCH] gnu: Add fillets-ng.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.26472.D26472.1492119633837.done@debbugs.gnu.org>
References: <20170413071128.28854-1-rekado@elephly.net>
	<874lxs9k88.fsf@fastmail.com>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <874lxs9k88.fsf@fastmail.com>
Date: Thu, 13 Apr 2017 23:40:25 +0200
Message-ID: <87wpao56ly.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26472-done@debbugs.gnu.org


Marius Bakke <mbakke@fastmail.com> writes:

>> +(define-public fillets-ng
>> +  (package
>> +    (name "fillets-ng")
>> +    (version "1.0.1")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "mirror://sourceforge/fillets/"
>> +                                  "Fish%20Fillets%20-%20Next%20Generation/"
>> +                                  version "/fillets-ng-" version ".tar.gz"))
>
> I would mention "fillets-ng-data" somewhere around this general area, so
> it isn't forgotten when someone comes here to update it. Looks good
> otherwise.

I forgot about adding the comment and pushed it to master with commit
e02f16636461985199b729f975ca6d57ac3cdd53.

I hope it’s clear to people who update this package that they should
also make sure that the data package matches.  I guess they’ll notice
anyway when they change the version string and the hash for
the “fillets-ng-data” input is wrong.

Thanks for the review!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net