all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26472-done@debbugs.gnu.org
Subject: bug#26472: [PATCH] gnu: Add fillets-ng.
Date: Thu, 13 Apr 2017 23:40:25 +0200	[thread overview]
Message-ID: <87wpao56ly.fsf@elephly.net> (raw)
In-Reply-To: <874lxs9k88.fsf@fastmail.com>


Marius Bakke <mbakke@fastmail.com> writes:

>> +(define-public fillets-ng
>> +  (package
>> +    (name "fillets-ng")
>> +    (version "1.0.1")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "mirror://sourceforge/fillets/"
>> +                                  "Fish%20Fillets%20-%20Next%20Generation/"
>> +                                  version "/fillets-ng-" version ".tar.gz"))
>
> I would mention "fillets-ng-data" somewhere around this general area, so
> it isn't forgotten when someone comes here to update it. Looks good
> otherwise.

I forgot about adding the comment and pushed it to master with commit
e02f16636461985199b729f975ca6d57ac3cdd53.

I hope it’s clear to people who update this package that they should
also make sure that the data package matches.  I guess they’ll notice
anyway when they change the version string and the hash for
the “fillets-ng-data” input is wrong.

Thanks for the review!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

      reply	other threads:[~2017-04-13 21:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-13  7:11 bug#26472: [PATCH] gnu: Add fillets-ng Ricardo Wurmus
2017-04-13 19:32 ` Marius Bakke
2017-04-13 21:40   ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpao56ly.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=26472-done@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.