From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dNoOv-0001qP-EY for guix-patches@gnu.org; Wed, 21 Jun 2017 18:47:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dNoOs-00082G-3y for guix-patches@gnu.org; Wed, 21 Jun 2017 18:47:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57685) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dNoOr-00082C-Vd for guix-patches@gnu.org; Wed, 21 Jun 2017 18:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dNoOr-0000IK-QQ for guix-patches@gnu.org; Wed, 21 Jun 2017 18:47:01 -0400 Subject: [bug#27355] [PATCH 3/7] gnu: Add libsigrokdecode. Resent-Message-ID: References: <20170614095813.1926-1-theodoros.for@openmailbox.org> <20170614095813.1926-3-theodoros.for@openmailbox.org> <20170619222054.028af180@scratchpost.org> From: Theodoros Foradis Message-ID: <87wp85ull4.fsf@openmailbox.org> In-reply-to: <20170619222054.028af180@scratchpost.org> Date: Wed, 21 Jun 2017 23:34:24 +0300 MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 27355@debbugs.gnu.org Hello, > the README lists some more dependencies: > > - doxygen (optional, only needed for the C API docs) > - graphviz (optional, only needed for the C API docs) > > Do you think it makes sense to build the API docs? > I recall adding those two as native-inputs but the API docs not building. I will try again though, and see if I can get it to work. It makes sense to me to have the docs. > Also, reading srd.c it seems that this library embeds Python. Is it still supposed to be a propagated-input then? It doesn't need the executable at runtime or anything. Users probably do need the Python standard library, so I guess it's OK... Hartmut, what do you think? > libsigrokdecode.pc, that is the pkg-config file lists python in Requires.private. If python is not propagated, libsigrok which depends on libsigrokdecode cannot be built. Maybe there is another way for this to work? I saw that done in another package. > Extra Python scripts for libsigrokdecode can be installed by the user into ${XDG_DATA_HOME-.local/share}/libsigrokdecode/decoders which is nice. > > Additionally, there's an environment variable SIGROKDECODE_DIR too. Does the package have to set any native-search-paths for this, to let the users know of the environment variable? -- Theodoros Foradis