From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: bug#27593: [PATCH v2] gnu: groff: Remove timestamps. Date: Sun, 09 Jul 2017 15:00:05 +0200 Message-ID: <87wp7hahpm.fsf@fastmail.com> References: <20170706025451.312ddebe@scratchpost.org> <20170706014708.16491-1-dannym@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUBpj-00063j-8a for bug-guix@gnu.org; Sun, 09 Jul 2017 09:01:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUBpe-0004xE-Qz for bug-guix@gnu.org; Sun, 09 Jul 2017 09:01:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55811) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUBpe-0004wc-Cm for bug-guix@gnu.org; Sun, 09 Jul 2017 09:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dUBpd-0006Ll-R4 for bug-guix@gnu.org; Sun, 09 Jul 2017 09:01:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20170706014708.16491-1-dannym@scratchpost.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Danny Milosavljevic , 27593@debbugs.gnu.org --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > Fixes . > > * gnu/packages/groff.scm (groff)[source]: Remove timestamps. > --- > gnu/packages/groff.scm | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/groff.scm b/gnu/packages/groff.scm > index 46e1ccf23..1a74194a6 100644 > --- a/gnu/packages/groff.scm > +++ b/gnu/packages/groff.scm > @@ -40,7 +40,23 @@ > (uri (string-append "mirror://gnu/groff/groff-" version > ".tar.gz")) > (sha256 (base32 > - "1998v2kcs288d3y7kfxpvl369nqi06zbbvjzafyvyl3pr7bajj1s")))) > + "1998v2kcs288d3y7kfxpvl369nqi06zbbvjzafyvyl3pr7bajj1s")) > + (modules '((guix build utils))) > + (snippet > + '(begin > + (substitute* "mdate.sh" > + (("^LANGUAGE=") " > + > +echo \"1 Jan 1970\" > +exit 0 > + > +")) It would be more obvious what's going on if we substitute the "mdate.sh" invocation from the Makefile instead. OTOH, this is more future-proof. No strong opinion, but feels a bit "hacky". Note that you can use \n here. > + (substitute* '("src/devices/grops/ps.cpp" > + "src/devices/grohtml/post-html.cpp" > + "src/roff/troff/input.cpp") > + (("time\\(0\\)") "0")) > + (substitute* "src/devices/gropdf/gropdf.pl" > + (("\\(time\\)") "(0)")))))) Are all of these really a cause of indeterminism in the build process? It looks like this could make "legitimate" uses of groff return epoch 0 at runtime, I'm not sure if that is okay. Which output files are fixed by these substitutions? Are there other ways to deal with the indeterminism, e.g. substitute them in place? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlliKNYACgkQoqBt8qM6 VPrgTgf/cceemkIgOwTf19dCw6YELn43WJs9aTOCU7J9sYbQjt3UIsUCktMIo64r 4azVtVZbROgXwJjxLYGqZLkH4vUJ5yzkPpUQUWvMPHf7SbcFC2yBGpu+cjGjFqdp Q5/0qomrY1BKm8dckvAlFLYBFyAVRWTCw/9v+u3SSOHHrKcBPvjjClxvkFcx8opm QSC1SyM3jOy+pa34mvWh6fDbzC0VVqPgdxcAKjO0iN+wmhEc2DQiFS+ptgUbzTNt J7g+dyGdiDQayi8SyZc4qKFn5iyc6TV28RxOYe86wJQ4TZ9Jr87dmQVGpLiQ56EQ WMhr/g8G3Vu8qxU5U/Gl2zm5vK1ttA== =GtU3 -----END PGP SIGNATURE----- --=-=-=--