From: ludo@gnu.org (Ludovic Courtès)
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: 28214@debbugs.gnu.org
Subject: [bug#28214] [PATCH] gnu: hdf5: Add output for Fortran interface.
Date: Thu, 31 Aug 2017 14:56:30 +0200 [thread overview]
Message-ID: <87wp5jsxoh.fsf@gnu.org> (raw)
In-Reply-To: <20170824.115309.1248640013266066348.post@thomasdanckaert.be> (Thomas Danckaert's message of "Thu, 24 Aug 2017 11:53:09 +0200 (CEST)")
Hi Thomas,
Thomas Danckaert <post@thomasdanckaert.be> skribis:
> From ea5b67230713bf79d625743eb18f57bf36d40407 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <post@thomasdanckaert.be>
> Date: Thu, 24 Aug 2017 11:00:59 +0200
> Subject: [PATCH] gnu: hdf5: Add output for fortran interface.
>
> * gnu/packages/maths.scm (hdf5) [native-inputs]: Add gfortran.
> [outputs]: Add "fortran".
> [arguments]: Enable Fortran compilation; add "/lib" directory of the fortran
> output to the runpath of the Fortran libs; patch "libhdf5.settings" to
> remove references to the C/C++/Fortran compilers; add a 'split phase to move
> all Fortran-related files to the the Fortran output store location.
[...]
> + (add-after 'configure 'patch-settings
> + (lambda _
> + ;; libhdf5.settings contains the full path of the
> + ;; compilers used, and its contents are included in
> + ;; libhdf5.so. We truncate the hashes to avoid
> + ;; unnecessary store references to those compilers:
> + (substitute* "src/libhdf5.settings"
> + (("(Fortran Compiler: /gnu/store/)([a-Z0-9]*)" all prefix hash)
> + (string-append prefix (string-take hash 10) "..."))
> + (("(C Compiler: /gnu/store/)([a-Z0-9]*)" all prefix hash)
> + (string-append prefix (string-take hash 10) "..."))
> + (("(C\\+\\+ Compiler: /gnu/store/)([a-Z0-9]*)" all prefix hash)
> + (string-append prefix (string-take hash 10) "...")))
Nice trick with the ellipses. :-)
How about making it two patches: one that adds this ‘patch-settings’
phase, and one that does the Fortran thing?
Apart from that it LGTM!
Thanks,
Ludo’.
prev parent reply other threads:[~2017-08-31 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 9:53 [bug#28214] [PATCH] gnu: hdf5: Add output for Fortran interface Thomas Danckaert
2017-08-31 12:56 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp5jsxoh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=28214@debbugs.gnu.org \
--cc=post@thomasdanckaert.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.