From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55918)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dosIL-0007fz-MY
	for guix-patches@gnu.org; Mon, 04 Sep 2017 10:24:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dosIE-0001PP-2w
	for guix-patches@gnu.org; Mon, 04 Sep 2017 10:24:09 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:40300)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dosID-0001PH-VT
	for guix-patches@gnu.org; Mon, 04 Sep 2017 10:24:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dosID-0004A6-NP
	for guix-patches@gnu.org; Mon, 04 Sep 2017 10:24:01 -0400
Subject: [bug#28285] Add heimdall
Resent-Message-ID: <handler.28285.B28285.150453499115937@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170829235829.7a4f55cd@lepiller.eu>
	<87d17cluww.fsf@fastmail.com> <20170903185259.4c056094@lepiller.eu>
Date: Mon, 04 Sep 2017 16:22:55 +0200
In-Reply-To: <20170903185259.4c056094@lepiller.eu> (Julien Lepiller's message
	of "Sun, 3 Sep 2017 18:53:06 +0200")
Message-ID: <87wp5ezgow.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 28285@debbugs.gnu.org

Hello,

Julien Lepiller <julien@lepiller.eu> skribis:

> I had to change the import of licenses and license field of all
> packages because heimdall depends on zlib, which is also a license
> name. Should I mention that in the commit message too? Should it be in
> a separate commit?

IMO it=E2=80=99s marginely better as a separate commit, but no big deal.

> From 77a0831ce91b61eca537d197e9c15720b3b6cf7e Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Tue, 29 Aug 2017 23:54:16 +0200
> Subject: [PATCH] gnu: Add heimdall.
>
> * gnu/packages/flashing-tools.scm (heimdall): New variable.

[...]

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((bin (string-append (assoc-ref outputs "out") "/bin")=
))
> +               (mkdir-p bin)
> +               (copy-file "bin/heimdall" (string-append bin "/heimdall"))
> +               (copy-file "bin/heimdall-frontend"
> +                          (string-append bin "/heimdall-frontend"))

You can write these as:

  (install-file "bin/heimdall" bin)
  =E2=80=A6

and also remove (mkdir-p bin).

OK with these changes!

Ludo=E2=80=99.