From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: 01/01: gnu: Put autoconf-related phases immediately after the 'unpack phase. Date: Mon, 04 Sep 2017 16:27:34 -0400 Message-ID: <87wp5enr9l.fsf@netris.org> References: <20170904041130.27802.58770@vcs0.savannah.gnu.org> <20170904041131.AE33520DD3@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doxyb-0004d5-Ds for guix-devel@gnu.org; Mon, 04 Sep 2017 16:28:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doxyW-00060j-G9 for guix-devel@gnu.org; Mon, 04 Sep 2017 16:28:09 -0400 Received: from world.peace.net ([50.252.239.5]:47450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1doxyW-0005ua-Aw for guix-devel@gnu.org; Mon, 04 Sep 2017 16:28:04 -0400 In-Reply-To: <20170904041131.AE33520DD3@vcs0.savannah.gnu.org> (Kei Kebreau's message of "Mon, 4 Sep 2017 00:11:31 -0400 (EDT)") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Kei Kebreau Cc: guix-devel@gnu.org kkebreau@posteo.net (Kei Kebreau) writes: > kkebreau pushed a commit to branch master > in repository guix. > > commit d10092b849153dc27cfed0a9601fde6c7bdec918 > Author: Kei Kebreau > Date: Sun Jul 30 21:02:35 2017 -0400 > > gnu: Put autoconf-related phases immediately after the 'unpack phase. > > * gnu/packages/audio.scm (audacity, rtmidi)[arguments]: Correct phases > accordingly. > * gnu/packages/bioinformatics.scm (mash, seek, vsearch, emboss, > htslib-for-sambamba)[arguments]: Likewise. > * gnu/packages/ci.scm (cuirass)[arguments]: Likewise. > * gnu/packages/compression.scm (minizip, xdelta)[arguments]: Likewise. > * gnu/packages/cpp.scm (libzen)[arguments]: Likewise. > * gnu/packages/crypto.scm (opendht)[arguments]: Likewise. > * gnu/packages/databases.scm (4store, mdbtools)[arguments]: Likewise. > * gnu/packages/debug.scm (stress-make)[arguments]: Likewise. > * gnu/packages/dns.scm (dnscrypt-proxy, dnscrypt-wrapper)[arguments]: > Likewise. > * gnu/packages/emacs.scm (emacs-pdf-tools)[arguments]: Likewise. > * gnu/packages/embedded.scm (libjaylink, openocd)[arguments]: Likewise. > * gnu/packages/engineering.scm (gerbv)[arguments]: Likewise. > * gnu/packages/erlang.scm (erlang)[arguments]: Likewise. > * gnu/packages/ftp.scm (weex)[arguments]: Likewise. > * gnu/packages/gnome.scm (dia)[arguments]: Likewise. > * gnu/packages/gnunet.scm (gnurl, guile-gnunet)[arguments]: Likewise. > * gnu/packages/gtk.scm (guile-rsvg, graphene)[arguments]: Likewise. > * gnu/packages/guile.scm (guildhall, guile-ics, guile-sqlite3)[arguments]: > Likewise. > * gnu/packages/ibus.scm (ibus-libpinyin)[arguments]: Likewise. > * gnu/packages/irc.scm (weechat)[arguments]: Likewise. > * gnu/packages/java.scm (classpath-devel)[arguments]: Likewise. > * gnu/packages/libreoffice.scm (libetonyek)[arguments]: Likewise. > * gnu/packages/libusb.scm (hidapi)[arguments]: Likewise. > * gnu/packages/linux.scm (gpm)[arguments]: Likewise. > * gnu/packages/logging.scm (glog)[arguments]: Likewise. > * gnu/packages/machine-learning.scm (ghmm)[arguments]: Likewise. > * gnu/packages/mail.scm (dovecot-trees, dovecot-libsodium-plugin, esmtp) > [arguments]: Likewise. > * gnu/packages/messaging.scm (freetalk, libmesode, libstrophe)[arguments]: > Likewise. > * gnu/packages/microcom.scm (microcom)[arguments]: Likewise. > * gnu/packages/ocaml.scm (ocaml-ssl)[arguments]: Likewise. > * gnu/packages/parallel.scm (slurm)[arguments]: Likewise. > * gnu/packages/pdf.scm (libharu)[arguments]: Likewise. > * gnu/packages/samba.scm (cifs-utils)[arguments]: Likewise. > * gnu/packages/serialization.scm (msgpack)[arguments]: Likewise. > * gnu/packages/shells.scm (scsh)[arguments]: Likewise. > * gnu/packages/telephony.scm (libiax2)[arguments]: Likewise. > * gnu/packages/textutils.scm (dotconf)[arguments]: Likewise. > * gnu/packages/version-control.scm (findnewest)[arguments]: Likewise. > * gnu/packages/video.scm (libmediainfo, mediainfo)[arguments]: Likewise. Thanks for working on this, but it looks like you didn't actually test building the modified packages. For example: > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index fe43d01..028fe06 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -685,7 +685,7 @@ the standard javac executable. The tool runs on JamVM instead of SableVM."))) > "--disable-gjdoc") > #:phases > (modify-phases %standard-phases > - (add-before 'configure 'bootstrap > + (add-after 'remove-unsupported-anootations 'bootstrap > (lambda _ > (zero? (system* "autoreconf" "-vif")))) > (add-after 'unpack 'remove-unsupported-annotations You mispelled 'annotations' in the name of the phase, and thus we lost our Java packages. Since this commit, there are now 119 newly failing jobs: https://hydra.gnu.org/eval/109773#tabs-now-fail I'm not sure how many of these new failures are due to this commit, but I suspect many of them are. Please test before you push to master. Mark