* Re: 01/01: gnu: Put autoconf-related phases immediately after the 'unpack phase.
[not found] ` <20170904041131.AE33520DD3@vcs0.savannah.gnu.org>
@ 2017-09-04 20:27 ` Mark H Weaver
2017-09-05 12:39 ` Kei Kebreau
0 siblings, 1 reply; 2+ messages in thread
From: Mark H Weaver @ 2017-09-04 20:27 UTC (permalink / raw)
To: Kei Kebreau; +Cc: guix-devel
kkebreau@posteo.net (Kei Kebreau) writes:
> kkebreau pushed a commit to branch master
> in repository guix.
>
> commit d10092b849153dc27cfed0a9601fde6c7bdec918
> Author: Kei Kebreau <kkebreau@posteo.net>
> Date: Sun Jul 30 21:02:35 2017 -0400
>
> gnu: Put autoconf-related phases immediately after the 'unpack phase.
>
> * gnu/packages/audio.scm (audacity, rtmidi)[arguments]: Correct phases
> accordingly.
> * gnu/packages/bioinformatics.scm (mash, seek, vsearch, emboss,
> htslib-for-sambamba)[arguments]: Likewise.
> * gnu/packages/ci.scm (cuirass)[arguments]: Likewise.
> * gnu/packages/compression.scm (minizip, xdelta)[arguments]: Likewise.
> * gnu/packages/cpp.scm (libzen)[arguments]: Likewise.
> * gnu/packages/crypto.scm (opendht)[arguments]: Likewise.
> * gnu/packages/databases.scm (4store, mdbtools)[arguments]: Likewise.
> * gnu/packages/debug.scm (stress-make)[arguments]: Likewise.
> * gnu/packages/dns.scm (dnscrypt-proxy, dnscrypt-wrapper)[arguments]:
> Likewise.
> * gnu/packages/emacs.scm (emacs-pdf-tools)[arguments]: Likewise.
> * gnu/packages/embedded.scm (libjaylink, openocd)[arguments]: Likewise.
> * gnu/packages/engineering.scm (gerbv)[arguments]: Likewise.
> * gnu/packages/erlang.scm (erlang)[arguments]: Likewise.
> * gnu/packages/ftp.scm (weex)[arguments]: Likewise.
> * gnu/packages/gnome.scm (dia)[arguments]: Likewise.
> * gnu/packages/gnunet.scm (gnurl, guile-gnunet)[arguments]: Likewise.
> * gnu/packages/gtk.scm (guile-rsvg, graphene)[arguments]: Likewise.
> * gnu/packages/guile.scm (guildhall, guile-ics, guile-sqlite3)[arguments]:
> Likewise.
> * gnu/packages/ibus.scm (ibus-libpinyin)[arguments]: Likewise.
> * gnu/packages/irc.scm (weechat)[arguments]: Likewise.
> * gnu/packages/java.scm (classpath-devel)[arguments]: Likewise.
> * gnu/packages/libreoffice.scm (libetonyek)[arguments]: Likewise.
> * gnu/packages/libusb.scm (hidapi)[arguments]: Likewise.
> * gnu/packages/linux.scm (gpm)[arguments]: Likewise.
> * gnu/packages/logging.scm (glog)[arguments]: Likewise.
> * gnu/packages/machine-learning.scm (ghmm)[arguments]: Likewise.
> * gnu/packages/mail.scm (dovecot-trees, dovecot-libsodium-plugin, esmtp)
> [arguments]: Likewise.
> * gnu/packages/messaging.scm (freetalk, libmesode, libstrophe)[arguments]:
> Likewise.
> * gnu/packages/microcom.scm (microcom)[arguments]: Likewise.
> * gnu/packages/ocaml.scm (ocaml-ssl)[arguments]: Likewise.
> * gnu/packages/parallel.scm (slurm)[arguments]: Likewise.
> * gnu/packages/pdf.scm (libharu)[arguments]: Likewise.
> * gnu/packages/samba.scm (cifs-utils)[arguments]: Likewise.
> * gnu/packages/serialization.scm (msgpack)[arguments]: Likewise.
> * gnu/packages/shells.scm (scsh)[arguments]: Likewise.
> * gnu/packages/telephony.scm (libiax2)[arguments]: Likewise.
> * gnu/packages/textutils.scm (dotconf)[arguments]: Likewise.
> * gnu/packages/version-control.scm (findnewest)[arguments]: Likewise.
> * gnu/packages/video.scm (libmediainfo, mediainfo)[arguments]: Likewise.
Thanks for working on this, but it looks like you didn't actually test
building the modified packages. For example:
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index fe43d01..028fe06 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -685,7 +685,7 @@ the standard javac executable. The tool runs on JamVM instead of SableVM.")))
> "--disable-gjdoc")
> #:phases
> (modify-phases %standard-phases
> - (add-before 'configure 'bootstrap
> + (add-after 'remove-unsupported-anootations 'bootstrap
> (lambda _
> (zero? (system* "autoreconf" "-vif"))))
> (add-after 'unpack 'remove-unsupported-annotations
You mispelled 'annotations' in the name of the phase, and thus we lost
our Java packages.
Since this commit, there are now 119 newly failing jobs:
https://hydra.gnu.org/eval/109773#tabs-now-fail
I'm not sure how many of these new failures are due to this commit, but
I suspect many of them are.
Please test before you push to master.
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 01/01: gnu: Put autoconf-related phases immediately after the 'unpack phase.
2017-09-04 20:27 ` 01/01: gnu: Put autoconf-related phases immediately after the 'unpack phase Mark H Weaver
@ 2017-09-05 12:39 ` Kei Kebreau
0 siblings, 0 replies; 2+ messages in thread
From: Kei Kebreau @ 2017-09-05 12:39 UTC (permalink / raw)
To: Mark H Weaver; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 4625 bytes --]
Mark H Weaver <mhw@netris.org> writes:
> kkebreau@posteo.net (Kei Kebreau) writes:
>
>> kkebreau pushed a commit to branch master
>> in repository guix.
>>
>> commit d10092b849153dc27cfed0a9601fde6c7bdec918
>> Author: Kei Kebreau <kkebreau@posteo.net>
>> Date: Sun Jul 30 21:02:35 2017 -0400
>>
>> gnu: Put autoconf-related phases immediately after the 'unpack phase.
>>
>> * gnu/packages/audio.scm (audacity, rtmidi)[arguments]: Correct phases
>> accordingly.
>> * gnu/packages/bioinformatics.scm (mash, seek, vsearch, emboss,
>> htslib-for-sambamba)[arguments]: Likewise.
>> * gnu/packages/ci.scm (cuirass)[arguments]: Likewise.
>> * gnu/packages/compression.scm (minizip, xdelta)[arguments]: Likewise.
>> * gnu/packages/cpp.scm (libzen)[arguments]: Likewise.
>> * gnu/packages/crypto.scm (opendht)[arguments]: Likewise.
>> * gnu/packages/databases.scm (4store, mdbtools)[arguments]: Likewise.
>> * gnu/packages/debug.scm (stress-make)[arguments]: Likewise.
>> * gnu/packages/dns.scm (dnscrypt-proxy, dnscrypt-wrapper)[arguments]:
>> Likewise.
>> * gnu/packages/emacs.scm (emacs-pdf-tools)[arguments]: Likewise.
>> * gnu/packages/embedded.scm (libjaylink, openocd)[arguments]: Likewise.
>> * gnu/packages/engineering.scm (gerbv)[arguments]: Likewise.
>> * gnu/packages/erlang.scm (erlang)[arguments]: Likewise.
>> * gnu/packages/ftp.scm (weex)[arguments]: Likewise.
>> * gnu/packages/gnome.scm (dia)[arguments]: Likewise.
>> * gnu/packages/gnunet.scm (gnurl, guile-gnunet)[arguments]: Likewise.
>> * gnu/packages/gtk.scm (guile-rsvg, graphene)[arguments]: Likewise.
>> * gnu/packages/guile.scm (guildhall, guile-ics, guile-sqlite3)[arguments]:
>> Likewise.
>> * gnu/packages/ibus.scm (ibus-libpinyin)[arguments]: Likewise.
>> * gnu/packages/irc.scm (weechat)[arguments]: Likewise.
>> * gnu/packages/java.scm (classpath-devel)[arguments]: Likewise.
>> * gnu/packages/libreoffice.scm (libetonyek)[arguments]: Likewise.
>> * gnu/packages/libusb.scm (hidapi)[arguments]: Likewise.
>> * gnu/packages/linux.scm (gpm)[arguments]: Likewise.
>> * gnu/packages/logging.scm (glog)[arguments]: Likewise.
>> * gnu/packages/machine-learning.scm (ghmm)[arguments]: Likewise.
>> * gnu/packages/mail.scm (dovecot-trees, dovecot-libsodium-plugin, esmtp)
>> [arguments]: Likewise.
>> * gnu/packages/messaging.scm (freetalk, libmesode, libstrophe)[arguments]:
>> Likewise.
>> * gnu/packages/microcom.scm (microcom)[arguments]: Likewise.
>> * gnu/packages/ocaml.scm (ocaml-ssl)[arguments]: Likewise.
>> * gnu/packages/parallel.scm (slurm)[arguments]: Likewise.
>> * gnu/packages/pdf.scm (libharu)[arguments]: Likewise.
>> * gnu/packages/samba.scm (cifs-utils)[arguments]: Likewise.
>> * gnu/packages/serialization.scm (msgpack)[arguments]: Likewise.
>> * gnu/packages/shells.scm (scsh)[arguments]: Likewise.
>> * gnu/packages/telephony.scm (libiax2)[arguments]: Likewise.
>> * gnu/packages/textutils.scm (dotconf)[arguments]: Likewise.
>> * gnu/packages/version-control.scm (findnewest)[arguments]: Likewise.
>> * gnu/packages/video.scm (libmediainfo, mediainfo)[arguments]: Likewise.
>
> Thanks for working on this, but it looks like you didn't actually test
> building the modified packages. For example:
>
>> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
>> index fe43d01..028fe06 100644
>> --- a/gnu/packages/java.scm
>> +++ b/gnu/packages/java.scm
>> @@ -685,7 +685,7 @@ the standard javac executable. The tool runs on JamVM instead of SableVM.")))
>> "--disable-gjdoc")
>> #:phases
>> (modify-phases %standard-phases
>> - (add-before 'configure 'bootstrap
>> + (add-after 'remove-unsupported-anootations 'bootstrap
>> (lambda _
>> (zero? (system* "autoreconf" "-vif"))))
>> (add-after 'unpack 'remove-unsupported-annotations
>
> You mispelled 'annotations' in the name of the phase, and thus we lost
> our Java packages.
>
> Since this commit, there are now 119 newly failing jobs:
>
> https://hydra.gnu.org/eval/109773#tabs-now-fail
>
> I'm not sure how many of these new failures are due to this commit, but
> I suspect many of them are.
>
> Please test before you push to master.
>
> Mark
This was caused by confusion on my end. I am working right now to find
and fix these errors. Thank you for your notification. My apologies.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-05 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170904041130.27802.58770@vcs0.savannah.gnu.org>
[not found] ` <20170904041131.AE33520DD3@vcs0.savannah.gnu.org>
2017-09-04 20:27 ` 01/01: gnu: Put autoconf-related phases immediately after the 'unpack phase Mark H Weaver
2017-09-05 12:39 ` Kei Kebreau
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.