From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37310)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dpaGR-0006M2-NC
	for guix-patches@gnu.org; Wed, 06 Sep 2017 09:21:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dpaGM-00031s-2y
	for guix-patches@gnu.org; Wed, 06 Sep 2017 09:21:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:43797)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dpaGL-00031g-Up
	for guix-patches@gnu.org; Wed, 06 Sep 2017 09:21:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dpaGL-00060k-P6
	for guix-patches@gnu.org; Wed, 06 Sep 2017 09:21:01 -0400
Subject: [bug#28288] [PATCH 1/5] vm: Add support for registering closures to
	make-iso9660-image.
Resent-Message-ID: <handler.28288.B28288.150470405523074@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170830071714.75f88e47@cbaines.net>
	<20170903105041.2925-1-mail@cbaines.net> <877exds2s3.fsf@gnu.org>
	<20170906080515.4764be7b@cbaines.net>
Date: Wed, 06 Sep 2017 15:20:44 +0200
In-Reply-To: <20170906080515.4764be7b@cbaines.net> (Christopher Baines's
	message of "Wed, 6 Sep 2017 08:05:32 +0100")
Message-ID: <87wp5c0xqr.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 28288@debbugs.gnu.org

Christopher Baines <mail@cbaines.net> skribis:

> On Tue, 05 Sep 2017 15:17:32 +0200
> ludo@gnu.org (Ludovic Court=C3=A8s) wrote:
>
>> Hi!
>>=20
>> Christopher Baines <mail@cbaines.net> skribis:
>>=20
>> > This mimics the functionality in the root-partition-initializer
>> > used in creating the QEMU image. This helps when trying to run guix
>> > system init from the generated ISO image.
>> >
>> > * gnu/build/vm.scm (make-iso9660-image): Add support for
>> > registering closures.=20=20
>>=20
>> [...]
>>=20
>> > +    (when register-closures?
>> > +      (display "registering closures...\n")
>> > +      (for-each (lambda (closure)
>> > +                  (register-closure
>> > +                   "/tmp/root"
>> > +                   (string-append "/xchg/" closure)
>> > +                   #:deduplicate? #f))
>> > +                closures))=20=20
>>=20
>> Was there any specific reason for #:deduplicate? #f here?
>
> Yep, the image creation process fails if this is not specified.
>
> error: cannot link
> `/tmp/root/gnu/store/.links/1wj8bqv0ygz606a0day0gk7w37prsnbg5z2im2yf025r0=
y6lqfs0'
> to
> `/tmp/root/gnu/store/00lgsgxvv1hfhl22yqmzsa3lrs5qa9my-firmware/lib/firmwa=
re/b43-open':
> Invalid cross-device link

Hmm, OK.  Looks like it=E2=80=99s trying to deduplicate between /tmp/root a=
nd
some other store.  (Or are we using a bind mount here?)

> There is probably another way around this though. I'm not sure what
> impact skipping the deduplication has on the size of the image.

It probably doesn=E2=80=99t matter much, so it=E2=80=99s not a blocker IMO.

Maybe leave an XXX comment mentioning the cross-device link issue.

Thanks!

Ludo=E2=80=99.