From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: [WIP][PATCH] download: Don't report the progress too fast Date: Wed, 20 Sep 2017 20:04:48 +0800 Message-ID: <87wp4teftr.fsf@member.fsf.org> References: <87d17ilhzq.fsf@member.fsf.org> <87shg978ao.fsf@gnu.org> <87mv652phq.fsf@member.fsf.org> <877ex6456z.fsf@gnu.org> <87d16ticpx.fsf@member.fsf.org> <87wp4z40pg.fsf@member.fsf.org> <87a81q6hwi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dufPn-0007Aa-R6 for guix-devel@gnu.org; Wed, 20 Sep 2017 09:51:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dufPm-0004XB-TK for guix-devel@gnu.org; Wed, 20 Sep 2017 09:51:47 -0400 In-Reply-To: <87a81q6hwi.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 19 Sep 2017 13:34:53 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org ludo@gnu.org (Ludovic Court=C3=A8s) writes: > iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis: > >> From d0c49ac1341c21d0efb069afb1521f61541e3eb4 Mon Sep 17 00:00:00 2001 >> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D >> Date: Sat, 16 Sep 2017 14:10:18 -0600 >> Subject: [PATCH] download: Don't report the progress too fast. >> >> * guix/utils.scm (): New record type. >> (call-with-progress-reporter): New procedure. >> * guix/build/download.scm (dump-port*, rate-limited, progress-reporter/f= ile): >> New procedures. >> (ftp-fetch, http-fetch): Use 'dump-port*'. >> (progress-proc): Remove procedure. >> * guix/scripts/substitute.scm (progress-report-port): Rewrite in terms of >> . >> (process-substitution): Adjust accordingly. > > LGTM. If you=E2=80=99ve confirmed that it works as intended, please push. > Done, thanks for the review!