From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e17qV-00027c-Nz for guix-patches@gnu.org; Sun, 08 Oct 2017 05:26:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e17qU-0002io-Rr for guix-patches@gnu.org; Sun, 08 Oct 2017 05:26:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46797) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e17qU-0002iS-Nn for guix-patches@gnu.org; Sun, 08 Oct 2017 05:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e17qU-0002If-Cm for guix-patches@gnu.org; Sun, 08 Oct 2017 05:26:02 -0400 Subject: [bug#28558] [PATCH] gnu: Add atool. Resent-Message-ID: From: Stefan =?UTF-8?Q?Reich=C3=B6r?= In-Reply-To: <87k206it1r.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 07 Oct 2017 22:47:44 +0200") References: <150611695436.21286.7179341499419388884.stgit@sandburg> <87o9q12sbz.fsf@xsteve.at> <87k206it1r.fsf@gnu.org> Date: Sun, 08 Oct 2017 11:25:54 +0200 Message-ID: <87wp46c7od.fsf@xsteve.at> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 28558@debbugs.gnu.org > Hi Stefan, > > Stefan Reich=C3=B6r skribis: > >>> On 23/09/17 07:49, Stefan Reich=C3=B6r wrote: >>>> * gnu/packages/compression.scm (atool): New variable. >>> Thanks for the patch. While adding all compression programs supported >>> (e.g. tar) as inputs is probably too much given their large number, I >>> think it would be good to add "file" and patch in the path to "file" >>> in bin/atool. WDYT? >> >> Thanks for your feedback. I don't think that file is an important tool >> for atool. At least I use only archives with the correct file extension. >> And all the archives that I remember that I downloaded from some site >> also provided the correct file extension. In that case file is not neede= d to >> detect the archive type. >> >> However, if you think that hard coding the full path to file is a good >> thing I will update my patch. It should be doable for me... > > As discussed earlier in another thread, I think it=E2=80=99s a good idea = to > hard-code absolute file names. Could you update the patch accordingly? > > TIA, > Ludo=E2=80=99. Hi Ludo! I am really busy for the next weeks. So I won't have time to do some work for Guix. I will try to improve my patches when I find the time. Stefan.