From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: Changing HTTP proxy settings in GuixSD
Date: Sat, 11 Nov 2017 05:12:20 -0500
Message-ID: <87wp2xdszf.fsf@netris.org>
References: <325f5d06-4bb1-294d-2768-07dde6d76090@fastmail.net>
	<87o9otbexn.fsf@gnu.org>
	<ed3da2a4-f6f6-badc-3ee0-59fb3fd57cfc@fastmail.net>
	<87mv3upurc.fsf@gmail.com>
	<m1ineizeo8.fsf@ordinateur-de-catherine--konrad.home>
	<87h8u1lr02.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60384)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1eDSmR-00071i-5q
	for guix-devel@gnu.org; Sat, 11 Nov 2017 05:12:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1eDSmM-0007NG-5Y
	for guix-devel@gnu.org; Sat, 11 Nov 2017 05:12:51 -0500
In-Reply-To: <87h8u1lr02.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Fri, 10 Nov 2017 23:15:41 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>

Hi,

ludo@gnu.org (Ludovic Court=C3=A8s) writes:
> It turned out to come from a typo in Guile 2.2=E2=80=99s web client, now =
fixed
> here:
>
>   https://git.savannah.gnu.org/cgit/guile.git/commit/?h=3Dstable-2.2&id=
=3D7d0d9e2c25c1e872cfc7d14ab5139915f1813d56

[...]

> diff --git a/module/web/http.scm b/module/web/http.scm
> index 993b50e..62f0624 100644
> --- a/module/web/http.scm
> +++ b/module/web/http.scm
> [...]
> @@ -1158,7 +1158,7 @@ three values: the method, the URI, and the version."
>          (put-symbol port scheme)
>          (put-string port "://")
>          (cond
> -         ((host string-index #\:)
> +         ((string-index host #\:)
>            (put-char #\[ port)
>            (put-string port host
>            (put-char port #\])))

There are 4 typos in the cond clause above, all introduced in this
commit:

  https://git.savannah.gnu.org/cgit/guile.git/commit/?id=3D96b994b6f815747c=
e2548123cc996d8132bd4781

which includes:

-         ((string-index host #\:)
-          (display #\[ port)
-          (display host port)
-          (display #\] port))
+         ((host string-index #\:)
+          (put-char #\[ port)
+          (put-string port host
+          (put-char port #\])))

In addition to the typo you fixed:

* The first call to 'put-char' above has its arguments reversed.
* The following line is missing its ')'.
* The last line has an extra ')'.

       Mark