From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQKPH-0003Mf-NS for guix-patches@gnu.org; Sat, 16 Dec 2017 16:54:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQKPD-0000Q0-4C for guix-patches@gnu.org; Sat, 16 Dec 2017 16:54:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:57313) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQKPC-0000PO-SE for guix-patches@gnu.org; Sat, 16 Dec 2017 16:54:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eQKPC-0004Mv-5w for guix-patches@gnu.org; Sat, 16 Dec 2017 16:54:02 -0500 Subject: [bug#29703] Improve Krita Resent-Message-ID: From: Kei Kebreau References: <1513210726.1193324.1204381152.68C7761A@webmail.messagingengine.com> <20171214115531.llwpyqjzjbwepvep@abyayala> <1513260171.940424.1204970752.5399B230@webmail.messagingengine.com> <20171214143921.blzsslbcig76ysob@abyayala> <1513264340.1671908.1205049896.4F42762D@webmail.messagingengine.com> Date: Sat, 16 Dec 2017 16:53:24 -0500 In-Reply-To: <1513264340.1671908.1205049896.4F42762D@webmail.messagingengine.com> (Mark Meyer's message of "Thu, 14 Dec 2017 16:12:20 +0100") Message-ID: <87wp1mz6ej.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mark Meyer Cc: 29703@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mark Meyer writes: > Thanks for your patience, from the log of gnunet.scm I think it should > be somthing like the appended one. > > Cheers, Mark > > On Thu, Dec 14, 2017, at 15:39, ng0 wrote: >> Hi, >>=20 >> we're almost there. It's just a couple of fixes that need to be applied: >>=20 >> Mark Meyer transcribed 7.7K bytes: >> > Ok, see the following patch. This should also be aligned with the comm= it >> > message conventions. >> >=20 >> > On Thu, Dec 14, 2017, at 12:55, ng0 wrote: >> > > Hi Mark, >> > >=20 >> > > Mark Meyer transcribed 5.4K bytes: >> > > > Hi, >> > > > I'm currently testing several changes to Krita, I've broken stuff = up >> > > > into three commits/patches which are attached. >> > > >=20 >> > > > These >> > > > - add a dependency to vc (vectorize Krita) >> > > > - enable OpenEXR >> > > > - enable JPEG (via libjpeg-turbo) >> > >=20 >> > > Thanks for the work on Krita. >> > > I haven't tested them, but it looks good. >> > > It would be okay to squash these commits into one, we've done this >> > > in the past in similar cases (see `git log gnu/packages/gnunet.scm` >> > > for libextractor for example). >> > >=20 >> > > > Cheers, Mark >>=20 >> > From 158497a7bf1b5672018189101fa5448623cecb1b Mon Sep 17 00:00:00 2001 >> > From: Mark Meyer >> > Date: Wed, 13 Dec 2017 23:49:09 +0100 >> > Subject: [PATCH] gnu: krita: Enhance krita >> >=20 >> > * gnu/packages/kde.scm (kirta)[inputs]: Add libjpeg-turbo to inputs. >> > * gnu/packages/kde.scm (krita)[inputs]: Add vc to native-inputs. >> > * gnu/packages/kde.scm (krita)[inputs]: Add OpenEXR support. >>=20 >> I would write: >>=20 >> gnu: krita: Enhance krita. >>=20 >> * gnu/packages/kde.scm (krita)[inputs]: Add 'libjpeg-turbo', 'ilmbase', >> 'openexr'. >> (native-inputs): Add 'vc'. >> (arguments)[configure-flags]: Add 'CMAKE_CXX_FLAGS' for ilmbase. >>=20 >>=20 >>=20 >> Or something like that. I'm not sure about the configure-flags wording. >> I don't know Krita so I can't really review if your changes work. I'll >> build it later tonight and see if it builds for me. >>=20 >> > --- >> > gnu/packages/kde.scm | 13 ++++++++++--- >> > 1 file changed, 10 insertions(+), 3 deletions(-) >> >=20 >> > diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm >> > index b5a3df2ca..89ad30ecd 100644 >> > --- a/gnu/packages/kde.scm >> > +++ b/gnu/packages/kde.scm >> > @@ -256,14 +256,18 @@ plugins, as well as code to create plugins, or c= omplete applications.") >> > (string-append "-DWITH_LibRaw=3D" >> > (assoc-ref %build-inputs "libraw")) >> > (string-append "-DWITH_TIFF=3D" >> > - (assoc-ref %build-inputs "libtiff"))))) >> > + (assoc-ref %build-inputs "libtiff")) >> > + (string-append "-DCMAKE_CXX_FLAGS=3D-I" >> > + (assoc-ref %build-inputs "ilmbase") >> > + "/include/OpenEXR")))) >> > (native-inputs >> > `(("curl" ,curl) >> > ("eigen" ,eigen) >> > ("extra-cmake-modules" ,extra-cmake-modules) >> > ("gettext-minimal" ,gettext-minimal) >> > ("kitemmodels" ,kitemmodels) >> > - ("qwt" ,qwt))) >> > + ("qwt" ,qwt) >> > + ("vc" ,vc))) >> > (inputs >> > `(("qtbase" ,qtbase) >> > ("qtdeclarative" ,qtdeclarative) >> > @@ -287,6 +291,7 @@ plugins, as well as code to create plugins, or com= plete applications.") >> > ("exiv2" ,exiv2) >> > ("lcms" ,lcms) >> > ("libpng" ,libpng) >> > + ("libjpeg-turbo" ,libjpeg-turbo) >> > ("zlib" ,zlib) >> > ("libx11" ,libx11) >> > ("libxcb" ,libxcb) >> > @@ -296,7 +301,9 @@ plugins, as well as code to create plugins, or com= plete applications.") >> > ("poppler-qt5" ,poppler-qt5) >> > ("libraw" ,libraw) >> > ("libtiff" ,libtiff) >> > - ("perl" ,perl))) >> > + ("perl" ,perl) >> > + ("ilmbase" ,ilmbase) >> > + ("openexr" ,openexr))) >> > (home-page "https://krita.org") >> > (synopsis "Digital painting application") >> > (description >> > --=20 >> > 2.15.0 >> >=20 >>=20 >>=20 >> --=20 >> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 >> GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys >> WWW: https://n0.is >> Email had 1 attachment: >> + signature.asc >> 1k (application/pgp-signature) I made tiny changes to the commit log and pushed this to master; you can close this bug. Thanks for contributing, Kei --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlo1ldQACgkQ5qXuPBlG eg3d1g/+N1K7TBnS1cvdrx1/m/xqIHNat3mzMrV78jP0GBGZOYXvYEhpkMmQxrOL 2v9YBXUznBD7R15YBEY1yyvkcLPARgxt7B+MlU7VICeag/dMiiyXFPjs3Sd/dO5n pRaxZXHtH7osxhSf44fMtwcgX4PU5PxyboTBt8gd8wqCQwDm+leSw9uk/t2pWg2e MLlsM+QuLCqBu4sQJKPoVFc2LlZgMvUU/E/gj+q0BHtD537Ieb3rcj7tBLu7Pyr0 uusG+JNmUEPKUhjddbCRut7n8hBkmqsG+fZAqm5HpJyIXYvHO3QnIGer03mQHIcO OVURMRJimrRWXg1DuFijKIo4MGyyENC/ImKHNWSg4RmBE9vjLVzVWtu9GhsCEhVI gWuA5pjOsKXWVfHFowlr5o7h1NQcdhZnNzPhyESJ8+4/7F3i5mIXSVfQJxnxOa+Q jTLeKlTcTL4vs7yhoma2R5/BZkBslBrvdLk6EZmlrTCM/QAOxB63JakOV/sNv6SZ F9BFRwfOXLVRCwKcRnmwE86/iQjXFJU/TT9n6qjr0qfzxvX/oPojO0K8qhxqMD7w APTitmmNePzVakQZ16ZwEctSI+zTm0J59+OOdbwjwoQ7mZQenN7gfS2rf02mM6uc 0BqIw1qiIGOHYnhXIXzeh8ROP0BMmgx249ce1khkXgE/cI5mRBE= =JLF0 -----END PGP SIGNATURE----- --=-=-=--